Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting #23

Open
hechth opened this issue Nov 4, 2024 · 1 comment
Open

Fix linting #23

hechth opened this issue Nov 4, 2024 · 1 comment

Comments

@hechth
Copy link
Collaborator

hechth commented Nov 4, 2024

Currently many linter warnings are suppressed - this should be addressed and actually fixed rather than suppressed.

@florian-huber
Copy link
Collaborator

@hechth good point!

So here is a better place the the current PR for my suggestion:

I would switch from pylint to ruff as we did for MS2DeepScore.

The workflow would need something like this:

      - name: Check style against standards using Ruff
        run: ruff check .

And we could add a config file ruff.toml or .ruff.toml, e.g. like this ruff.toml. In principle this should also work with something like tool.ruff in the existing toml-file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants