Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using DataFrame or xarray internally #3

Open
florian-huber opened this issue Sep 6, 2022 · 1 comment
Open

Consider using DataFrame or xarray internally #3

florian-huber opened this issue Sep 6, 2022 · 1 comment

Comments

@florian-huber
Copy link
Collaborator

Currently the data is stored in COO form with

  • .row & .column for the 2D indexing
  • .data as a numpy structured array which essentially is a table, able to contain different data types.

This functionality is also provided by pandas DataFrames or xarray Datasets which would bring more functionalities and make the code more readible. Main questions are:

  • Effort worth it?
  • How about performance?
@florian-huber
Copy link
Collaborator Author

This is (or was) tested in #4 .
While this makes part of the code more accessible, performance is much better when using numpy structured arrays. In particular slicing was much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant