Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room reminders #19

Open
Natureshadow opened this issue Nov 3, 2020 · 3 comments
Open

Room reminders #19

Natureshadow opened this issue Nov 3, 2020 · 3 comments

Comments

@Natureshadow
Copy link
Contributor

I would like the reminder bot to be able to remind the whole room of something.

Actually, this is currently possible using a "power level reflection attack" ;): If the bot has sufficient power, a user can schedule a reminder containinig @room, and the bot will wake up the room. This is a simple method, but can be abused.

A simple solution would be to:

  • When scheduling a reminder, check for @room in the reminder text
  • If it contains @room, check the power level of the bot on whether it may trigger room notifications
  • If it can, compare the power level of the sending user
  • If they can send room notifications, schedule the reminder; if not, error out and/or remove the @room from the reminder

That still carries the issue that it will notifiy all room mebers three times: on creating the reminder, on confirming the reminder, and on sending the reminder. I would thus prefer to have a new subcommand to trigger room reminders, so the original reminder command does not have to contain @room.

Thoughts please; I will implement this if the maintainers are positive enough that they want it and the open decisions have been decided.

@Sleuth56
Copy link

I think this is a great idea. I've just started using this bot and quickly wanted a way of reminding specific users or a whole room without each user clicking the thumbs up button. My initial thought for the user end of this is.

!remind <users> <date> <message>
!remind @user1 @user2 1 hour submit the new PR.

@auscompgeek
Copy link

@lerker100 You can already do that by mentioning the users in the message.

@Sleuth56
Copy link

Testing the @room functionality the bot only notifies the whole room twice. Once while creating the reminder and again once its triggered. I think that's the correct way of doing it. The power level stuff should get worked out though. For larger rooms this could be a huge problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants