Replies: 5 comments
-
Given that no maintainer has reacted for a few months: @emiel perhaps you might just create a PR? I'm also interested in having proper type hints. I could assist if required. |
Beta Was this translation helpful? Give feedback.
-
Based on my experience implementing type annotations in other libraries, I'm going to ask everyone to avoid making their own PRs for this. I can barely get it right, trying to review someone else modifying almost every line is impossible. |
Beta Was this translation helpful? Give feedback.
-
Thanks @lukasjuhrich for your message. I've switched jobs and am not using this library at this moment and so I won't be picking up this task myself. @davidism: I trust your experience but someone needs to make a start on this if we want to make this happen. I'll leave it up to the maintainer on how to proceed... but we need an answer first I guess. |
Beta Was this translation helpful? Give feedback.
-
IMHO, but annotations don't change the behavior in the code. If you have tests, you can run them and be sure that nothing is broken. Perhaps in the future I would add them if there is support from the authors for the merge. |
Beta Was this translation helpful? Give feedback.
-
They don't but they do create a ton more noise when we don't get them exactly right and people start making issues about it that require more releases. I'll reiterate: please don't work on this unless you are literally a typing expert and will guarantee that you will keep responding to further typing issues for the next year after they're released. |
Beta Was this translation helpful? Give feedback.
-
Thanks for flask-login. We still use it and we'd like to see type annotations added.
I could work on this if there is interest.
Beta Was this translation helpful? Give feedback.
All reactions