-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Screen flickering and voliatile image artifacts #122
Comments
Wow, I've never heard anything like that 😧 Do you have two screens? Does it reproduce if you only leave one of them in the config? |
Yeah, I have dual screen laptop
Flickering still persist |
I cannot possibly imagine how we can be affecting screen contents if all we do is receive a frame and copy it into a new image for further professing What if you replace this entire part with Lines 203 to 226 in 5e0732e
Or what if you comment out this part, does the flickering go away? This is basically receiving frames and not doing anything with them at all. wluma/src/frame/capturer/wlroots.rs Lines 126 to 131 in 5e0732e
|
Changes in Maybe this is not about image as is, maybe it related to change backlight so fast? |
I did not expect that flickering would persist with changes to Let's comment one more line and see if it changes anything, replace all of this please with Lines 201 to 226 in 77bac5a
Similarly to test your idea that it is backlight change that could be the culprit, you could maybe try to replace this part with wluma/src/frame/capturer/wlr_export_dmabuf_unstable_v1.rs Lines 155 to 162 in 77bac5a
By the way, I just pushed some major update to |
First case - Please note that all previous tests I'm doing on tag 4.4.1 Fresh unchanged |
Right, sorry, comment out line 201 and all of the unsafe block in the end too, lines 229-234. |
It's f**king magic Give me please some time to make more tests in different circumstances. |
A new Would you like to try it out? Just pull the latest If you do get to try it, please report any issues you face with it, because I want to make this protocol a new default. And also, on my own hardware I observed that with the new protocol I am getting occasional
Could you tell me if you see them? (they pop up relatively frequently). If you don't see them, could you comment this line and try again? wluma/src/frame/capturer/wayland.rs Lines 431 to 432 in 8e81a8f
I see them without |
changes in
I tried fresh master with |
This might sound crazy but does your screen flicker when you screen share an entire screen (without wluma running) on https://mozilla.github.io/webrtc-landing/gum_test.html? I assume you use xdg-desktop-portal-wlr for that. |
The reason I say this is because upon re-reading this thread I realized that I initially misread your message, specifically that after commenting both lines below still produces flickering:
Basically, wluma consists of 3 parts: request screen contents from wlroots, import the image & get its "luma" value, predict & change brightness using luma value. The two code actions above correspond to the two latter activities, so by commenting them out, we are really left with just asking wlroots to get us screen contets, and nothing else - and any kind of screen sharing does that too! |
In this case I havent flickering during fullscreen sharing |
I'm completely at a loss, I'll be honest, I think the only way forward is to comment stuff out until we find what exactly we have to comment in order to stop flickering from happening. I just pushed If it still flickers, could you also experiment with |
It's very strange...
|
Also I find one more thing It visible very clear on dark backgrounds and almost invisible with light ones |
It sounds unpredictable, I can't explain why doing the same operation more and less frequently causes flickering. I suspect if you keep running this or I think I would look for an issue elsewhere... Some other software, running in parallel? Maybe check BIOS for anything relevant to GPU? Just throwing some ideas... 🤔 |
As I mentioned before I have Tomorrow I'll try to play with the "better" version and keep you posted |
Cool thanks! I think although a lot of |
Found this project, which might be closer to wluma than just a screen sharing in a browser, maybe worth giving it a go and seeing if you see any artifacts using it: https://github.com/russelltg/wl-screenrec |
Steps for reproducing the issue
wluma
What is the buggy behavior?
Right after start app screen starts flickering (with frequency near 5 Hz) and sometimes appear dark rectangles on light parts of screen image which persist on the same place after change image (scroll out or change browser tab). I saw this only in Chrome but I can't be sure that it don't appear in other apps
What is the expected behavior?
Clear screen image without flickering
Logs
Version
4.4.1
Environment
The text was updated successfully, but these errors were encountered: