Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements.txt has modules with missing versions #8

Open
sidgairo18 opened this issue May 5, 2024 · 3 comments
Open

Requirements.txt has modules with missing versions #8

sidgairo18 opened this issue May 5, 2024 · 3 comments

Comments

@sidgairo18
Copy link

sidgairo18 commented May 5, 2024

Hi,
Firstly, congratulations on the good work, and making your project publicly available.

When setting up the project with the dependencies in the requirements.txt file, some modules do not have their versions mentioned, and the code does not seem to be forward compatible (with the latest versions). For instance pytorch-lightning, etc.

Would be great if you could also update that, since it took a lot of effort to finally get the current version up and running.

Many Thanks :)

P.S.: Maybe even a pip-freeze of your conda / virtualenv would be really helpful :D

@mbanani
Copy link
Owner

mbanani commented May 15, 2024

Hi @sidgairo18,

Sorry you faced some issues with setting up the repo and I am glad you were able to get it working. Unfortunately, pytorch-lightning has been causing a lot of issues as it doesn't seem to maintain good compatibility. If you want to submit a PR updating the requirements to the version that worked for you, I will happily accept it. Thank you.

@sidgairo18
Copy link
Author

hi @mbanani,

Actually later on only the preprocessing code works (which I could send a pull request for). However, the training / eval still run into a lot of issues which are hair-pulling to fix :(

Like I had requested, would be great if you could please share the pip freeze requirements.txt file for your original environment (if possible). or any other working solution you could provide.

Will be very grateful for your help :)

Thanks,
Sid

@mbanani
Copy link
Owner

mbanani commented May 17, 2024

Hi Sid! I did this work while I was a PhD student and I have already graduated. I will see if I still have access to the cluster and update this accordingly if I can. My guess is that the following 3 packages (pytorch-lightning, lightning-bolts, lightly would be the root of the problem, so for now, I would suggest finding the package version as of November 2022 which is when this work was submitted.

Also, looking at the requirements, I would think that the preprocessing stuff is mainly stable. I am curious, which packages you ran into issues with with preprocessing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants