Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few UI improvement's requests #131

Open
vishal-kumar4 opened this issue Jun 18, 2024 · 5 comments
Open

Few UI improvement's requests #131

vishal-kumar4 opened this issue Jun 18, 2024 · 5 comments

Comments

@vishal-kumar4
Copy link
Contributor

vishal-kumar4 commented Jun 18, 2024

1)The info button seems kinda broken as functionality wise it displays info on click where as it would be better if we enable it to display info on hover for certain time and then info gets vanish.
Screenshot 2024-06-18 at 1 40 58 PM
2)Wouldn't it be good if we add a logo of cftracker on left of "CFTRACKER" on the page like any other standard websites.

3)Issues page has route name as "/comments" flow wise it will be better if we have route as "/issues" itself and when i click on issues button page takes time to render info and loading animation on this page is stopping too early leaving the screen blank for few seconds
Screenshot 2024-06-18 at 1 45 04 PM

4)We don't have a login/sign up option anywhere in the UI where as we are required to login to make a comment in the issues page, it will be good if we can create a login/sign-up page for users.

@mbashem
Copy link
Owner

mbashem commented Jun 18, 2024

Thanks for the suggestions.

  • Regarding 1, I am not sure if changing it to hover will be a good idea or not, but I will keep it in mind. But I will not change it now.
  • I will implement 2nd and 3rd suggestions or if you want you can implement them.
  • The 4th one required GitHub authentication. I use a third-party package for this page. I will check how to improve this.

@vishal-kumar4
Copy link
Contributor Author

Sure, thanks for reading them patiently, i would like to implement the 2nd and 3rd, will raise a PR real quick ..

@vishal-kumar4
Copy link
Contributor Author

other minor issues have been addressed in the PR, one point :About the 3rd point in the first comment in this issue : about the loading animation : we will need to change the flow of how we are using the lazy rendering and using [suspense, fallback] for loading , and instead can go with use state hook for the components for displaying loading animation flawlessly, bcoz i tried and researched a little current flow has the issue of early stopping of the loading screen ..

@mbashem
Copy link
Owner

mbashem commented Jun 19, 2024

Sure, if you can improve the current system, go ahead.

@vishal-kumar4
Copy link
Contributor Author

Thanks sure, ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants