Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOC headings seems to break section names? #32

Closed
ronaldtse opened this issue Apr 8, 2020 · 7 comments
Closed

TOC headings seems to break section names? #32

ronaldtse opened this issue Apr 8, 2020 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@ronaldtse
Copy link
Contributor

image

=> "INTRODUCTIONPrinciples and rules followed"

This is from https://github.com/glossarist/iev-document .

@ronaldtse ronaldtse added the bug Something isn't working label Apr 8, 2020
@ronaldtse
Copy link
Contributor Author

@w00lf could you help take care of this? Thanks!

@opoudjis
Copy link
Contributor

opoudjis commented Apr 20, 2020

if you get to it before me, @w00lf, the simplification of headings for rendering in TOC is done in isodoc, lib/isodoc/function/utils.rb, header_strip(): presumably replacing <br/> with space.

@opoudjis
Copy link
Contributor

... no, it is in the JS scripts.html; the code to build it statically is overridden.

@opoudjis
Copy link
Contributor

This is from the comedy of errors of metanorma/isodoc#79. The request to move away from Javascript dates from TWO YEARS AGO, and the followup to feature-improve static TOC has been unactioned as metanorma/isodoc#113.

I will need to investigate what disabling static ToC will do.

@opoudjis
Copy link
Contributor

opoudjis commented Apr 21, 2020

So

  • The cleanup of headings in Static ToC (Ruby) is much better than that in Dynamic ToC (JS), which is basically unimplemented; hence the run-ins we are seeing.
  • I have no idea if we are meant to be moving away from Dynamic ToC or not, Create static ToC for Html output isodoc#79 is muddled and full of short term thinking.
  • I have no idea if we are meant to use jQuery or not.
  • I do know that replicating code to do the same thing in JS and Ruby is leading to confusion.
  • I am going to shove in a cheap jQuery function to implement the highlighting requested in Improve ToC isodoc#113, and disable Dynamic ToC.

@ronaldtse
Copy link
Contributor Author

We are meant to have a degradable Dynamic ToC. Ie. Even if there is no JS enabled the ToC still works, perhaps without highlighting.

@opoudjis
Copy link
Contributor

There is no reason to implement the same functionality twice in this case. Urgent I speak to you.

opoudjis added a commit to metanorma/metanorma-generic that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/isodoc that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-ribose that referenced this issue Apr 21, 2020
opoudjis added a commit that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-iso that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-itu that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-m3aawg that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-mpfa that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-ogc that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-ribose that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-ribose that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-un that referenced this issue Apr 21, 2020
opoudjis added a commit to metanorma/metanorma-vg that referenced this issue Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants