Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🕹️] Bug: Light dark mode and loader button in upgrade section #981

Closed
JeevaRamanathan opened this issue Oct 14, 2024 · 21 comments
Closed

Comments

@JeevaRamanathan
Copy link
Contributor

JeevaRamanathan commented Oct 14, 2024

What side quest or challenge are you solving?

Bug

Points

W.r.t to Quest

Description

This issue address two bugs.

  1. Light dark mode
    In billing page or upgrade modal the button background is not visible when hovered.
    image
  2. Loader State
    Regardless of which plan is chosen all options starts loading with the title Redirecting to stripe...
    image

Expected Behaviour
Button should be visible on hover and only selected plan should load.

@JeevaRamanathan
Copy link
Contributor Author

/assign

Copy link

oss-gg bot commented Oct 14, 2024

Assigned to @JeevaRamanathan! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@nil-frontend
Copy link

/assign

Copy link

oss-gg bot commented Oct 15, 2024

This issue is already assigned to another person. Please find more issues here.

@Nishantkumar012
Copy link

is this issue still open

@shivanshu-2002
Copy link

/assign

Copy link

oss-gg bot commented Oct 18, 2024

This issue is already assigned to another person. Please find more issues here.

@sanyamhbtu
Copy link

/assign

Copy link

oss-gg bot commented Oct 19, 2024

This issue is already assigned to another person. Please find more issues here.

@JeevaRamanathan
Copy link
Contributor Author

Hi @mfts,

I have a question/request regarding the conflict in #982/#1144. Since another contributor worked on the same issue (as no issue was raised previously by them), I was unknowingly working on it as well. Upon noticing that, I discarded my commit in #982 to avoid conflicts and rebased to the main branch to pull in the latest changes and push only the required changes.

However, that PR automatically locked the conversation, which led me to create an unnecessary new PR for the same issue instead of adding a new commit to the original PR due to the lock.

Is there a specific reason for this lock, or should I have handled it differently?

Additionally requesting you close this issue from your end.

@JeevaRamanathan JeevaRamanathan removed their assignment Oct 20, 2024
@7uyash
Copy link

7uyash commented Oct 20, 2024

/assign

@oss-gg oss-gg bot assigned 7uyash Oct 20, 2024
Copy link

oss-gg bot commented Oct 20, 2024

Assigned to @7uyash! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Copy link

oss-gg bot commented Oct 22, 2024

@7uyash, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Copy link

oss-gg bot commented Oct 22, 2024

@7uyash has not opened a PR for this issue within 48 hours. They have been unassigned from the issue; anyone can now take it up.

@oss-gg oss-gg bot unassigned 7uyash Oct 22, 2024
@Gururaj26
Copy link

/assign

Copy link

oss-gg bot commented Oct 23, 2024

Assigned to @Gururaj26! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Gururaj26 Gururaj26 removed their assignment Oct 23, 2024
@Gururaj26
Copy link

/assign

Copy link

oss-gg bot commented Oct 23, 2024

Assigned to @Gururaj26! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Gururaj26
Copy link

@JeevaRamanathan Could you close this issue? As this is already addressed. I accidentally started working on this issue, later figured out that it was already resolved.

@Gururaj26 Gururaj26 removed their assignment Oct 23, 2024
@JeevaRamanathan
Copy link
Contributor Author

@Gururaj26. Oops! It seems there was a misunderstanding. However, if you had noticed the comments, I was asking a question to Marc in the same conversation after it was merged: #981 (comment) and mentioned that he could close it afterward. But that's fine; I will close it. Thanks!

Copy link

oss-gg bot commented Oct 24, 2024

@Gururaj26, please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12 hours, you will be unassigned automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants