You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the library and the whole scrivener libraries!
I have an issue with the header links generated by scrivener_html. If I am reading the code correctly there is currently no checking if the next/prev page does indeed exist?
In my opinion, checking if the next/prev pages exist (by looking the the total_pages in relation to the page_number) and skipping prev/next should do the trick. This would also mean the special cases for the first and last page at https://github.com/mgwidmann/scrivener_html/blob/master/lib/scrivener/html/seo.ex#L42 could be removed as they would be covered.
If you are ok with a PR regarding this I can look into it!
The text was updated successfully, but these errors were encountered:
Thanks for the library and the whole scrivener libraries!
I have an issue with the header links generated by scrivener_html. If I am reading the code correctly there is currently no checking if the next/prev page does indeed exist?
In my opinion, checking if the next/prev pages exist (by looking the the
total_pages
in relation to thepage_number
) and skipping prev/next should do the trick. This would also mean the special cases for the first and last page at https://github.com/mgwidmann/scrivener_html/blob/master/lib/scrivener/html/seo.ex#L42 could be removed as they would be covered.If you are ok with a PR regarding this I can look into it!
The text was updated successfully, but these errors were encountered: