Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension/Revision of function writeTables() #28

Closed
3 tasks
michaelgruenstaeudl opened this issue Feb 6, 2024 · 0 comments · Fixed by #29
Closed
3 tasks

Extension/Revision of function writeTables() #28

michaelgruenstaeudl opened this issue Feb 6, 2024 · 0 comments · Fixed by #29

Comments

@michaelgruenstaeudl
Copy link
Owner

michaelgruenstaeudl commented Feb 6, 2024

Renaming

  • Please rename any variable and function called "verbose" or "verboseInformation()" with "printCovStats()" (or words to that effect), which is a more factual description.
  • Please rename function called "writeTables()" with "printCovValsAsTable()" (or words to that effect), which is a more factual description.

Extension/Revision of function writeTables()

  • It would be fantastic if the coverage statistics saved via writeTables() could be calculated irrespective of the value of analysisSpecs$isIRCheck. After all, the IRCheck only has a relevance for step 3 of verboseInformation() in helpers.R, where writeTables() in its current implementation expects the exact location information of the IRs. What is needed is a second, simpler version of writeTables() that does not operate on the four regions of a quadripartite genome but simply on the entire undivided genome. This simpler version is simply executed when IRCheck=False.
@michaelgruenstaeudl michaelgruenstaeudl changed the title Second, more generalistic version of writeTables() Extension/Revision of function writeTables() Feb 6, 2024
@alephnull7 alephnull7 linked a pull request Feb 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant