From cbd45b12dc9290a0b214f2d67c67d2d37d2becad Mon Sep 17 00:00:00 2001
From: Eng Zer Jun <engzerjun@gmail.com>
Date: Tue, 5 Dec 2023 00:00:01 +0800
Subject: [PATCH] Avoid allocations with `(*regexp.Regexp).MatchString` (#2679)

We should use `(*regexp.Regexp).MatchString` instead of
`(*regexp.Regexp).Match([]byte(...))` when matching string to avoid
unnecessary `[]byte` conversions and reduce allocations.

func BenchmarkMatch(b *testing.B) {
	for i := 0; i < b.N; i++ {
		if match := versionRe.Match([]byte("v1")); !match {
			b.Fail()
		}
	}
}

func BenchmarkMatchString(b *testing.B) {
	for i := 0; i < b.N; i++ {
		if match := versionRe.MatchString("v1"); !match {
			b.Fail()
		}
	}
}

goos: linux
goarch: amd64
pkg: go-micro.dev/v4/api/handler/event
cpu: AMD Ryzen 7 PRO 4750U with Radeon Graphics
BenchmarkMatch-16          	11430127	       127.4 ns/op	       2 B/op	       1 allocs/op
BenchmarkMatchString-16    	12220628	        97.54 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	go-micro.dev/v4/api/handler/event	3.822s

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
---
 api/handler/event/event.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/api/handler/event/event.go b/api/handler/event/event.go
index 7dc7b7bf44..9ce36becdd 100644
--- a/api/handler/event/event.go
+++ b/api/handler/event/event.go
@@ -54,7 +54,7 @@ func evRoute(namespace, myPath string) (string, string) {
 
 	// Treat /v[0-9]+ as versioning
 	// /v1/foo/bar => topic: v1.foo action: bar
-	if len(parts) >= 2 && versionRe.Match([]byte(parts[0])) {
+	if len(parts) >= 2 && versionRe.MatchString(parts[0]) {
 		topic := namespace + "." + strings.Join(parts[:2], ".")
 		action := eventName(parts[1:])