Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type on class PlannedProcess #1027

Closed
Tracked by #1466
sujaypatil96 opened this issue Jun 30, 2023 · 3 comments
Closed
Tracked by #1466

Add type on class PlannedProcess #1027

sujaypatil96 opened this issue Jun 30, 2023 · 3 comments
Labels
closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork enhancement New feature or request schema change Term updates to NMDC Schema

Comments

@sujaypatil96
Copy link
Collaborator

sujaypatil96 commented Jun 30, 2023

Children of class PlannedProcess (Pooling, Extraction, LibraryPreparation) are being used extensively in the NEON metadata ingest pipeline to create instances of above mentioned processes.

It is useful to know the type of instances being created, like how we indicate for Biosamples that they are of type nmdc:Biosample. Similarly, it is useful to annotate instances of PlannedProcess objects (and their children) with type as well. For example, Pooling process instances will have type nmdc:Pooling, Extraction process instances will be of type nmdc:Extraction and so forth. This is useful redundancy to have, because it helps while writing queries against the database.

So we are requesting a modeling change where you assert the slot type on PlannedProcess, which will carry over into its child classes as well.

@sujaypatil96 sujaypatil96 added enhancement New feature or request schema change Term updates to NMDC Schema labels Jun 30, 2023
@turbomam
Copy link
Member

OK. What should the range be? There are type values in the data already that are nmdc-schema class URIs, enumerate values, or free text string. My preference is for an enumeration in this case, but maybe we can make stub classes in the future.

@sujaypatil96
Copy link
Collaborator Author

Related to #1030

@kheal
Copy link
Contributor

kheal commented May 23, 2024

type is now a slot on NamedThing which is the parent class of PlannedProcess on Berkeley fork.

@kheal kheal closed this as completed May 23, 2024
@kheal kheal added the closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork enhancement New feature or request schema change Term updates to NMDC Schema
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants