Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 - should be compatible with AOT/trimming #1875

Open
baywet opened this issue Oct 14, 2024 · 2 comments
Open

V2 - should be compatible with AOT/trimming #1875

baywet opened this issue Oct 14, 2024 · 2 comments

Comments

@baywet
Copy link
Member

baywet commented Oct 14, 2024

While we don't need that on GA, we should at least ensure that there are no design decisions which are going to corner us.

We should at the mimum:

  • add a test project
  • add a target of net5/6/8

There are a number of places in this repo where reflection is present, and we should avoid it for performance/reliability reasons.

See kiota-dotnet for the test project setup.

@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Oct 23, 2024

@baywet we already have a trimming test project set up in V2 here https://github.com/microsoft/OpenAPI.NET/tree/release/2.0.0/test/Microsoft.OpenApi.Trimming.Tests

@baywet
Copy link
Member Author

baywet commented Oct 23, 2024

@MaggieKimani1 this is most likely not working as expected as the library csproj

  • is missing net8 target (and maybe 5 and 6 depending on how low we want to support trimming)
  • is missing the IsTrimmable/IsAotCompatible property

See an example

Also readers is not setup as indicated by this comment

The fact the project is not yelling at us for things like these comforts me in this hypothesis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants