Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you publish a package that supports @mui v5 ? #185

Open
cyulin opened this issue Oct 27, 2021 · 16 comments
Open

Can you publish a package that supports @mui v5 ? #185

cyulin opened this issue Oct 27, 2021 · 16 comments

Comments

@cyulin
Copy link

cyulin commented Oct 27, 2021

material-ui-color is a very good project and I want to continue using it.

But the latest version of the package(v1.2.0) still uses @material-ui/core v4. I use @mui/material v5 in my project, and I found that @material-ui/core and @mui/material have style conflicts.

thank you very much!

@ramanjaneya-karnati
Copy link

I'm looking for this package to support MUI V5.

@hiaselhans
Copy link
Contributor

yes please! :)

thanks for the great package...

@roborew
Copy link

roborew commented Nov 8, 2021

Looks like this is already fixed in the master branch:
#178
But likely needs further testing and a tagged release.
@mikbry is it possible to get a tagged release for V5 support?

@ValetCona
Copy link

I'm sorry, I accidentally made a Mention.
I'm looking forward to the release :)

@ThabrezAhmed
Copy link

Hi,
Any update on the support release for mui v5?

Thanks in advance.

@mikbry
Copy link
Owner

mikbry commented Dec 5, 2021

Sorry for the lack of update on migration to mui v5, but I need futher tests as it completely breaks compatibility with v4. Actual master branch isn't passing tests so I am not ok with that.

@mikbry
Copy link
Owner

mikbry commented Dec 5, 2021

I just released mui-color 2.0.0-beta.1 which will be the port of Material-ui-color to Mui v5. There are several bugs, need to update the doc, I will fix them or if you want you could make a PR.

@mikbry
Copy link
Owner

mikbry commented Dec 5, 2021

I will also revert all v5 changes in this repo, so I could fix new issues in material-ui-color

@mikbry mikbry pinned this issue Dec 5, 2021
@ThabrezAhmed
Copy link

Hi @mikbry, Any updates on release

@mikbry
Copy link
Owner

mikbry commented Jan 3, 2022

@ThabrezAhmed For Mui v5 I created a new package mui-color : https://github.com/mikbry/mui-color . It is an alpha, design need to be enhanced.

@solshuffle
Copy link

Hi, thank you for the package :)
I just changed to MUI5, and trying this out, but I'm getting an error because it's trying to use @mui/styles, which should be removed if using MUI5 (or to be used only temporarily)

./node_modules/mui-color/esm/index.js:1:278
Module not found: Can't resolve '@mui/styles'

@rafde
Copy link

rafde commented Jan 24, 2022

I had to include the following in my webpack config (I am using nextjs with it)

// resolves material-ui-colors breaking the app
		config.resolve.alias[ '@material-ui/core/Box' ] = path.resolve( basePath, './node_modules/@mui/material/Box' );
		config.resolve.alias[ '@material-ui/core/Button' ] = path.resolve( basePath, './node_modules/@mui/material/Button' );
		config.resolve.alias[ '@material-ui/core/Divider' ] = path.resolve( basePath, './node_modules/@mui/material/Divider' );
		config.resolve.alias[ '@material-ui/core/FormControl' ] = path.resolve( basePath, './node_modules/@mui/material/FormControl' );
		config.resolve.alias[ '@material-ui/core/FormHelperText' ] = path.resolve( basePath, './node_modules/@mui/material/FormHelperText' );
		config.resolve.alias[ '@material-ui/core/Input' ] = path.resolve( basePath, './node_modules/@mui/material/Input' );
		config.resolve.alias[ '@material-ui/core/InputAdornment' ] = path.resolve( basePath, './node_modules/@mui/material/InputAdornment' );
		config.resolve.alias[ '@material-ui/core/InputLabel' ] = path.resolve( basePath, './node_modules/@mui/material/InputLabel' );
		config.resolve.alias[ '@material-ui/core/Popover' ] = path.resolve( basePath, './node_modules/@mui/material/Popover' );
		config.resolve.alias[ '@material-ui/core/Slider' ] = path.resolve( basePath, './node_modules/@mui/material/Slider' );
		config.resolve.alias[ '@material-ui/core/styles' ] = path.resolve( basePath, './node_modules/@mui/styles' );
		config.resolve.alias[ '@material-ui/core/TextField' ] = path.resolve( basePath, './node_modules/@mui/material/TextField' );
		config.resolve.alias[ '@material-ui/core/Tooltip' ] = path.resolve( basePath, './node_modules/@mui/material/Tooltip' );

where basePath is sent for relative path for my other repos that call my library repo, which is where this config lives

@JeanFabry
Copy link

Hey, thanks for the great package and the alpha.
The alpha seems almost fully operational ! 😃

@cykoder
Copy link

cykoder commented Aug 25, 2022

i have published a fixed version of this package that works with latest mui5: https://www.npmjs.com/package/material5-ui-color out of the box

@viclafouch
Copy link

viclafouch commented Aug 29, 2022

This package (https://viclafouch.github.io/mui-color-input/) handles this problem, supports both React 17 / 18 and MUI V5

@mikbry
Copy link
Owner

mikbry commented Aug 29, 2022

I will update Mui-color support based on new Mui and react 17/ 18 , https://github.com/mikbry/mui-color

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests