Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile issues #2

Open
dsvensson opened this issue Feb 3, 2024 · 1 comment · May be fixed by #3
Open

Compile issues #2

dsvensson opened this issue Feb 3, 2024 · 1 comment · May be fixed by #3

Comments

@dsvensson
Copy link

dsvensson commented Feb 3, 2024 •
edited
Loading

I'm getting issues due to either g++ version or cgal version. Some of the classes are deemed to not implement all functionality. Would you mind adding a GitHub action as that serves both as testing for you, as well as executable build env documentation for others.

The steps in the docs dont help.

Fwiw I'm on Ubuntu 23.10.

tried with:

  • g++ (Ubuntu 13.2.0-4ubuntu3) 13.2.0
  • clang 16.0.6 (15)
  • clang 17.0.2 (1~exp1ubuntu2.1)

Error:

/usr/bin/c++ -DBOOST_ALL_NO_LIB -DCGAL_USE_BASIC_VIEWER -DCGAL_USE_GMPXX=1  -std=c++20 -g -O0 -g -std=gnu++20 -fdiagnostics-color=always -frounding-math -MD -MT CMakeFiles/t3d2map.dir/src/main.cpp.o -MF CMakeFiles/t3d2map.dir/src/main.cpp.o.d -o CMakeFiles/t3d2map.dir/src/main.cpp.o -c /home/daniel/Development/home/quake/t3d2map/src/main.cpp
In file included from /usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polygon_mesh.h:19,
                 from /usr/include/CGAL/Polygon_mesh_processing/triangulate_hole.h:20,
                 from /home/daniel/Development/home/quake/t3d2map/src/main.cpp:17:
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h: In instantiation of ‘bool CGAL::internal::triangulate_hole_polyline_with_cdt(const PointRange&, Tracer&, Visitor&, const Validity_checker&, const Traits&, typename Traits::FT) [with PointRange = std::vector<CGAL::Point_3<CGAL::Epeck> >; Tracer = Tracer_polyline_incomplete<CGAL::Triple<int, int, int>, std::back_insert_iterator<std::vector<CGAL::Triple<int, int, int> > >, std::back_insert_iterator<std::vector<std::pair<int, int> > > >; Visitor = const FaceUVMapCopyVisitor; Validity_checker = CGAL::Polygon_mesh_processing::triangulate_hole_polyline<std::vector<CGAL::Point_3<CGAL::Epeck> >, std::vector<CGAL::Point_3<CGAL::Epeck> >, std::back_insert_iterator<std::vector<CGAL::Triple<int, int, int> > >, CGAL::Named_function_parameters<bool, CGAL::internal_np::use_2d_constrained_delaunay_triangulation_t, CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property> > >(const std::vector<CGAL::Point_3<CGAL::Epeck> >&, const std::vector<CGAL::Point_3<CGAL::Epeck> >&, std::back_insert_iterator<std::vector<CGAL::Triple<int, int, int> > >, const CGAL::Named_function_parameters<bool, CGAL::internal_np::use_2d_constrained_delaunay_triangulation_t, CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property> >&)::Always_valid; Traits = CGAL::Epeck; typename Traits::FT = CGAL::Lazy_exact_nt<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> >]’:
/usr/include/CGAL/Polygon_mesh_processing/triangulate_hole.h:780:45:   required from ‘OutputIterator CGAL::Polygon_mesh_processing::triangulate_hole_polyline(const PointRange1&, const PointRange2&, OutputIterator, const NamedParameters&) [with PointRange1 = std::vector<CGAL::Point_3<CGAL::Epeck> >; PointRange2 = std::vector<CGAL::Point_3<CGAL::Epeck> >; OutputIterator = std::back_insert_iterator<std::vector<CGAL::Triple<int, int, int> > >; NamedParameters = CGAL::Named_function_parameters<bool, CGAL::internal_np::use_2d_constrained_delaunay_triangulation_t, CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property> >]’
/usr/include/CGAL/Polygon_mesh_processing/triangulate_hole.h:819:37:   required from ‘OutputIterator CGAL::Polygon_mesh_processing::triangulate_hole_polyline(const PointRange&, OutputIterator, const CGAL::Named_function_parameters<NP_T, NP_Tag, NP_Base>&) [with PointRange = std::vector<CGAL::Point_3<CGAL::Epeck> >; OutputIterator = std::back_insert_iterator<std::vector<CGAL::Triple<int, int, int> > >; NP_T = bool; NP_Tag = CGAL::internal_np::use_2d_constrained_delaunay_triangulation_t; NP_Base = CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property>]’
/usr/include/CGAL/Polygon_mesh_processing/triangulate_faces.h:96:35:   required from ‘bool CGAL::Polygon_mesh_processing::internal::Triangulate_polygon_mesh_modifier<PolygonMesh>::triangulate_face_with_hole_filling(face_descriptor, PolygonMesh&, VPM, Visitor, const NamedParameters&) [with VPM = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >::Property_map<CGAL::SM_Vertex_index, CGAL::Point_3<CGAL::Epeck> >; Visitor = FaceUVMapCopyVisitor; NamedParameters = CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property>; PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; face_descriptor = CGAL::SM_Face_index]’
/usr/include/CGAL/Polygon_mesh_processing/triangulate_faces.h:233:46:   required from ‘bool CGAL::Polygon_mesh_processing::internal::Triangulate_polygon_mesh_modifier<PolygonMesh>::operator()(face_descriptor, PolygonMesh&, const NamedParameters&) [with NamedParameters = CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property>; PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; face_descriptor = CGAL::SM_Face_index]’
/usr/include/CGAL/Polygon_mesh_processing/triangulate_faces.h:365:17:   required from ‘bool CGAL::Polygon_mesh_processing::triangulate_faces(FaceRange, PolygonMesh&, const NamedParameters&) [with FaceRange = CGAL::Iterator_range<CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >::Index_iterator<CGAL::SM_Face_index> >; PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; NamedParameters = CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property>]’
/usr/include/CGAL/Polygon_mesh_processing/triangulate_faces.h:423:27:   required from ‘bool CGAL::Polygon_mesh_processing::triangulate_faces(PolygonMesh&, const NamedParameters&) [with PolygonMesh = CGAL::Surface_mesh<CGAL::Point_3<CGAL::Epeck> >; NamedParameters = CGAL::Named_function_parameters<FaceUVMapCopyVisitor, CGAL::internal_np::visitor_t, CGAL::internal_np::No_property>]’
/home/daniel/Development/home/quake/t3d2map/src/main.cpp:1001:29:   required from here
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1349:11: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘start_planar_phase’
 1349 |   visitor.start_planar_phase();
      |   ~~~~~~~~^~~~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1393:13: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1393 |     visitor.end_planar_phase(false);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1406:13: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1406 |     visitor.end_planar_phase(false);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1412:17: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1412 |         visitor.end_planar_phase(false);
      |         ~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1421:13: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1421 |     visitor.end_planar_phase(false);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1461:13: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1461 |     visitor.end_planar_phase(false);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1491:13: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1491 |     visitor.end_planar_phase(false);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1509:17: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1509 |         visitor.end_planar_phase(false);
      |         ~~~~~~~~^~~~~~~~~~~~~~~~
/usr/include/CGAL/Polygon_mesh_processing/internal/Hole_filling/Triangulate_hole_polyline.h:1518:11: error: ‘const class FaceUVMapCopyVisitor’ has no member named ‘end_planar_phase’
 1518 |   visitor.end_planar_phase(true);
      |   ~~~~~~~~^~~~~~~~~~~~~~~~
@dsvensson
Copy link
Author

Too new cgal. I'll prep a PR to fix Conan and cmake later. Fails to convert my t3d though :(

dsvensson added a commit to qw-ctf/t3d2map that referenced this issue Feb 3, 2024
@dsvensson
Fix conan cgal selection and add GH Action.
67c19b5 
fixes mildred#2
dsvensson added a commit to qw-ctf/t3d2map that referenced this issue Feb 3, 2024
@dsvensson
Fix conan cgal selection and add GH Action.
03d2311 
fixes mildred#2
@dsvensson dsvensson linked a pull request Feb 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conan cgal selection and add GH Action. qw-ctf/t3d2map
1 participant
@dsvensson