Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the use of PluginFetchResourceListFromDrupal #70

Open
2 of 4 tasks
mjordan opened this issue Sep 1, 2020 · 1 comment
Open
2 of 4 tasks

Deprecate the use of PluginFetchResourceListFromDrupal #70

mjordan opened this issue Sep 1, 2020 · 1 comment
Assignees

Comments

@mjordan
Copy link
Owner

mjordan commented Sep 1, 2020

PluginFetchResourceListFromDrupalView should be used instead of PluginFetchResourceListFromDrupal since it offers as much flexibility in determining what resources to check as site admins can build into a View.

Steps to take in deprecating PluginFetchResourceListFromDrupal:

  • Note in the README that this plugin is being deprecated.
  • Add a note to the plugin source file and sample_islandora_jsonapi_config.yml that the plugin is being deprecated.
  • At the defined date (end of 2020) remove the plugin's class file and the sample config from the Riprap codebase.
  • Remove descriptions from the README of using this plugin.
@mjordan mjordan self-assigned this Sep 1, 2020
mjordan added a commit that referenced this issue Sep 1, 2020
@mjordan
Copy link
Owner Author

mjordan commented Apr 28, 2021

The "Generate Riprap configuration settings" option in Islandora Riprap's settings form assumes use of this plugin. When it is removed, that code needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant