Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure when running test suite in conda-forge feedstock #92

Open
h-vetinari opened this issue Nov 19, 2021 · 1 comment
Open

Test failure when running test suite in conda-forge feedstock #92

h-vetinari opened this issue Nov 19, 2021 · 1 comment

Comments

@h-vetinari
Copy link

Hey all

overrides is also being packaged for conda-forge (not sure if people were aware), but it seems the so-called "feedstock" hasn't seen much attention from its maintainer in recent times. I rectified that, and now overrides is up-to-date again. 🥳

In bringing up the packaging "recipe" to best-practices, I'm now also running the test suite as a precondition for publishing a new build. However, there's one test failure (both on 5.0.1, as well as 6.0.1 / 6.1.0) when doing so**:

=================================== FAILURES ===================================
________________ EnforceTests.test_nested_typevar_in_signature _________________

self = <test_enforce__py38.EnforceTests testMethod=test_nested_typevar_in_signature>

    def test_nested_typevar_in_signature(self):
        T = TypeVar("T")
        K = TypeVar("K")
    
        def typevarred(t: Optional[T]) -> Optional[K]:
            pass
    
        def typed(t: Optional[str]) -> Optional[int]:
            pass
    
        def untyped(t):
            pass
    
        def return_typed(t) -> Optional[int]:
            pass
    
        ensure_signature_is_compatible(typevarred, untyped, True)
        ensure_signature_is_compatible(typevarred, typed, True)
        ensure_signature_is_compatible(untyped, typevarred, True)
        ensure_signature_is_compatible(typed, typevarred, True)
        ensure_signature_is_compatible(untyped, return_typed, True)
>       with self.assertRaises(TypeError):
E       AssertionError: TypeError not raised

tests/test_enforce__py38.py:429: AssertionError

If someone from the maintainers here wants to participate in the packaging for conda-forge, please just let me know. :)

** I've currently skipped that particular test when running the test suite to unblock the new versions, but I'd like to avoid that of course, hence this issue. See also conda-forge/overrides-feedstock#22 & the CI run therein.

@mkorpela
Copy link
Owner

mkorpela commented Oct 9, 2022

@h-vetinari is this still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants