Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dataset submit only validates fields after doing a bunch more stuff #581

Open
pierre-nedelec opened this issue Apr 17, 2024 · 1 comment
Labels
component: client issues regarding the CLI project: Core topic: UI/UX type: bug Something isn't working type: enhancement New feature or request

Comments

@pierre-nedelec
Copy link

Describe the bug
Only validates field after some lengthy operations, and error message doesn't say whether the command should be rerun or whether we can still change the field after the fact.

To Reproduce
Steps to reproduce the behavior:

medperf dataset submit -p 99 -d path1 -l path1 --name name --location "loc" --description "123456789012345678901"

output:

MedPerf 0.1.2
❌ Field Validation Error:
- description: ensure this value has at most 20 characters.

Expected behavior
Run such validation first so we don't have to wait 10' to see that message.

@hasan7n
Copy link
Contributor

hasan7n commented Apr 19, 2024

Thank you for reporting this!

@hasan7n hasan7n added type: bug Something isn't working component: client issues regarding the CLI project: Core topic: UI/UX labels Apr 19, 2024
@aristizabal95 aristizabal95 self-assigned this May 6, 2024
@aristizabal95 aristizabal95 added the type: enhancement New feature or request label Jun 17, 2024
@aristizabal95 aristizabal95 removed their assignment Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: client issues regarding the CLI project: Core topic: UI/UX type: bug Something isn't working type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants