Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for adding new examples #120

Open
Aakash-kaushik opened this issue Sep 28, 2020 · 12 comments
Open

Guidelines for adding new examples #120

Aakash-kaushik opened this issue Sep 28, 2020 · 12 comments

Comments

@Aakash-kaushik
Copy link
Contributor

Aakash-kaushik commented Sep 28, 2020

So this issue gives out a template or a guide that can be followed or kept in mind when writing new examples:

  • The examples should be well documented in terms that can easily be understood by people entering the field of Machine learning or have been in it for a long time.

  • Make examples simple enough so the user can basically grasp what he needs to build his own full-fledged model and don't over-complicate the examples but still try to include all library functionalities related to that example.

  • A little bit more can be written about parameters or functionalities which are implemented differently in mlpack than what the common notion is or which might confuse the user.

  • When adding the comments and writing tutorials try to mention why you followed a particular strategy in the example and maybe mention what are the implications of the strategy that you took and what are the other ways a user can proceed with the example.

  • Some examples that show things that are particularly interesting or practical can take a divergence from these guidelines and can become a bit complicated, maybe an example of such could be GANs but not limited to it.

  • And please take a look at the example that exists before and try to avoid redundant examples.

And lastly, this is just a guide, not strict rules so have fun writing examples and show your creativity. :)

@Aakash-kaushik Aakash-kaushik changed the title Guideline for adding new examples Guidelines for adding new examples Sep 28, 2020
@shrit
Copy link
Member

shrit commented Sep 28, 2020

@Aakash-kaushik Thank you for writing this, I think we can add some points about tutorials too.
It is quite straightforward to write examples. Most of the above points can be agreed on by most of us.
However, it would interesting to add some points about comments and tutorials considering each example, users would like to know why we followed this pattern in writing code 👍

@birm
Copy link
Member

birm commented Sep 28, 2020

I think we should leave space for especially interesting or practical examples, even if they aren't especially simple.

@Aakash-kaushik
Copy link
Contributor Author

@Aakash-kaushik Thank you for writing this, I think we can add some points about tutorials too.
It is quite straightforward to write examples. Most of the above points can be agreed on by most of us.
However, it would interesting to add some points about comments and tutorials considering each example, users would like to know why we followed this pattern in writing code 👍

I need to think about how and what to write and then i will add it.

@Aakash-kaushik
Copy link
Contributor Author

I think we should leave space for especially interesting or practical examples, even if they aren't especially simple.

Yes that is correct I will add that point too.

@Aakash-kaushik
Copy link
Contributor Author

Hey @shrit, @birm give it a look now.

@zoq
Copy link
Member

zoq commented Sep 28, 2020

@Aakash-kaushik Thanks for putting this together, can you run a spell checker over the text?

@Aakash-kaushik
Copy link
Contributor Author

Aakash-kaushik commented Sep 28, 2020

@Aakash-kaushik Thanks for putting this together, can you run a spell checker over the text?

Edited the issue, Take a look now.

@mlpack-bot
Copy link

mlpack-bot bot commented Oct 28, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@shrit
Copy link
Member

shrit commented Oct 28, 2020

@rcurtin do you think we can pin this issue?

@rcurtin rcurtin pinned this issue Oct 30, 2020
@rcurtin
Copy link
Member

rcurtin commented Oct 30, 2020

Yeah! Not a bad idea. Done. 👍 Thanks @Aakash-kaushik for originally writing these up!

@shrit shrit unpinned this issue May 31, 2021
@shrit shrit pinned this issue May 31, 2021
@shrit shrit unpinned this issue Jan 15, 2022
@Naidu-Saikiran
Copy link

I will add some example tutorial using mlpack. I will document the examples well understood and precise. Please assign this to me

@Aakash-kaushik
Copy link
Contributor Author

I will add some example tutorial using mlpack. I will document the examples well understood and precise. Please assign this to me

Hey @Saikirannaidu225, welcome and feel free to take those up and create a draft PR for those.
But this issue is just a skeleton and only serves as a guideline on how things should be and not as an actual issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants