-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing variables are not always skipped #17
Comments
Even worse, there doesn't even need to be another variable in the actual.csv file, i.e.:
Lists variable b as 100%. |
What is the expected behavior? Should actual.b always fail or simply be ignored? |
I would expect it to be a failure since the actual result isn't like the expected/base result. |
Can you please check if 9c0a0aa fixes the problem as you would expect! Thanks. |
Unfortunately I currently haven't any software setup for compiling csv-compare on my own but looking from the changeset it looks correct, you changed the warning into an error and also changed the graph. But I can't say for sure until the above tests has been tried. Thanks! |
Added the fix for modelica-tools#17 Missing variables are not always skipped
CSV Compare does not skip variables which aren't present in both csv files in some cases.
For example the following base.csv:
and actual.csv:
Note that b exists in base.csv but not in actual.csv, and x is missing from base.csv but exists in actual.csv. In the generated report the variable b is listed with a 100% success rate. This is a rather severe bug since the user get the impression that everything is fine and the variable produces the correct result! It does however leave a warning in the log, saying that b has been skipped (which it apparently haven't).
Log:
Command used:
Version:
The text was updated successfully, but these errors were encountered: