Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge or reject duplicate requests #222

Open
chandler05 opened this issue Jul 3, 2021 · 7 comments · May be fixed by #225
Open

Merge or reject duplicate requests #222

chandler05 opened this issue Jul 3, 2021 · 7 comments · May be fixed by #225
Assignees
Labels
enhancement New feature or request

Comments

@chandler05
Copy link
Member

The Problem

Duplicate requests happen often

Possible Solution

If an exact duplicate of another request is requested, we either merge them into a single internal request or reject the duplicate request

@chandler05 chandler05 added the enhancement New feature or request label Jul 3, 2021
@chandler05 chandler05 changed the title Merge or delete duplicate requests Merge or reject duplicate requests Jul 3, 2021
@violine1101
Copy link
Member

Problem here: How do we determine if we're dealing with duplicate requests? Does the message match exactly? Do we check ticket IDs and if the same tickets are mentioned in both requests?

@chandler05
Copy link
Member Author

I think we could just establish a standard form of requests to make them all look the same and then do an exact match.

@violine1101
Copy link
Member

I'd like to avoid that. It's unintuitive for the users and it's annoying to enforce, even with MojiraBot. Just for this feature that doesn't seem worth it.

@chandler05
Copy link
Member Author

Well, I still think exact match would be the better solution, however alternatively we could check the pattern of words being in between, before, or after the tickets as well as the tickets themselves, so "X duplicates Y" would be a dupe of "X duplicate of Y" but not "X and Y are duplicates" because the words are arranged in a different pattern.

@chandler05 chandler05 self-assigned this Jul 10, 2021
@chandler05 chandler05 linked a pull request Jul 10, 2021 that will close this issue
@violine1101
Copy link
Member

If we only use exact match people will just abuse this system by altering their messages a little bit just to fool the bot at which point we again need to reimplement this. It's just not worth the effort. Just warn users who intentionally post duplicate requests and if they continue kick them from the server.

@chandler05
Copy link
Member Author

This isn't a feature for stopping those users. This is for people who accidentally make duplicate requests, which there are quite a number of, and by doing the exact matching we can filter out the most obvious duplicates

@Jack-McKalling
Copy link

How about some kind of way for the bot to groupmention other requests that have the exact same ticket ID in them, so we can determine if it is a duplicate of one of them?

Similar to how comments are added, it could add a list of potential duplicates by just copying the text with link of/to the internal request. Like this:

User#1234
MC-123456 Something needs to be done about this report
Go To
Message in #java-requests

Potential duplicate requests:
MC-123456 This report needs this and that (link)

Someday at 12:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants