Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data manipulation in monarch-ui to ontobio/biolink-api #356

Open
kshefchek opened this issue May 29, 2020 · 1 comment
Open

Move data manipulation in monarch-ui to ontobio/biolink-api #356

kshefchek opened this issue May 29, 2020 · 1 comment
Milestone

Comments

@kshefchek
Copy link
Contributor

kshefchek commented May 29, 2020

Due to the natural evolution of the two codebases, the monarch-ui currently does a lot of json manipulation after fetching data from Biolink. Ideally, this would be minimized and biolink would provide the ui a closer representation of what is needed for our views.

Examples:

  • Node pages make two calls to Biolink - neighbors, and {type}/{id}, followed by a lot of data manipulation - see Node.vue
  • Calls to getNeighborhood are followed by lot's of data munging - see getNeighborhood, this reminds me of "fetchClassInfo" from our legacy app
  • Operating on BBOP Graphs browser side, see getNeighborhood above and BBOPGraphUtils.js
  • Manipulating evidence EvidenceViewer.vue
@kshefchek kshefchek added this to the 2.0 milestone May 29, 2020
@kshefchek
Copy link
Contributor Author

See related/overlapping
#346
#353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant