Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TODO #1652

Open
mattleibow opened this issue Mar 12, 2021 · 4 comments
Open

[BUG] TODO #1652

mattleibow opened this issue Mar 12, 2021 · 4 comments

Comments

@mattleibow
Copy link
Contributor

mattleibow commented Mar 12, 2021

Description

  1. SkCamera.h and SkMatrix44.h are DEPRECATED.
    Use SkM44 if you want to have 3d transformations.

  2. GrContext::createBackendTexture functions that initialize the texture no longer
    guarantee that all the data has been uploaded and the gpu is done with the texture.
    Instead the client can assume the upload work has been submitted to the gpu and they
    must wait for that work to finish before deleting the texture. This can be done via
    their own synchronization or by passing in a finish proc into the create calls which
    will be called when it is safe to delete the texture (at least in terms of work
    done during the create).
    https://review.skia.org/286517

  3. Add api on GrContext, updateBackendTexture that will upload new data to a
    GrBackendTexture.
    https://review.skia.org/288909

  4. Added GrContext::oomed() which reports whether Skia has seen a GL_OUT_OF_MEMORY
    error from Open GL [ES] or VK_ERROR_OUT_OF_*_MEMORY from Vulkan.
    https://review.skia.org/298216

  5. GrContext::abandoned()

@gmurray81
Copy link
Contributor

BTW, I think

GrContext::abandoned()

would help with #1573 and #1642

since I didn't see a SkiaSharp level way to tell if another SKSwapChainPanel had abandonded the resources for a GrContext. But I'm not sure the current abandon behavior is appropriate anyhow?

@taublast
Copy link
Contributor

Not really a bug but imperative for skiasharp v3?..

@mattleibow
Copy link
Contributor Author

For this, we have them mostly done:

  1. We have the SKMatrix44 now
  2. We can add this overload later if it is needed as it is additive
  3. Not sure we need this API, if we do, we can add it later
  4. We can add this later if there is a need
  5. This has been added already

We have some and the others are new APIs that we can add later.

@mattleibow
Copy link
Contributor Author

Was there any specific item you needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants