Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect that classes which extend moodleform* call parent:: in overridden functions #183

Open
jrchamp opened this issue Aug 30, 2024 · 0 comments

Comments

@jrchamp
Copy link
Contributor

jrchamp commented Aug 30, 2024

We ran into a few issues when parent:: wasn't being called for an overridden function, so I was inspired by #106. I thought maybe this would go into #92, but it should probably be applied to core code also. Here's a quick list of examples that would be good to include sooner rather than later. I hope this helps! ❤️

Call parent::

  • moodleform
    • set_data
    • validation
  • moodleform_mod
    • data_postprocessing
    • data_preprocessing
    • definition_after_data
    • standard_grading_coursemodule_elements
    • (and all from moodleform)

Method override should not exist

  • moodleform_mod
    • get_data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant