diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3ecf45f5..12dcd602 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -121,25 +121,25 @@ jobs: IGNORE_PATHS: tests/fixtures - name: PHP Lint - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci phplint - name: PHP Copy/Paste Detector continue-on-error: true # This step will show errors but will not fail - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci phpcpd - name: PHP Mess Detector continue-on-error: true # This step will show errors but will not fail - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci phpmd - name: Moodle Code Checker - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci codechecker --max-warnings 0 - name: Moodle PHPDoc Checker - if: ${{ always() }} + if: ${{ !cancelled() }} run: | if [ ${{ matrix.plugin-ci }} == "^3" ]; then moodle-plugin-ci phpdoc @@ -148,25 +148,29 @@ jobs: fi - name: Validating - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci validate - name: Check upgrade savepoints - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci savepoints - name: Mustache Lint - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci mustache - name: Grunt - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci grunt --max-lint-warnings 0 - name: PHPUnit tests - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci phpunit - name: Behat features - if: ${{ always() }} + if: ${{ !cancelled() }} run: moodle-plugin-ci behat --profile chrome + + - name: Mark cancelled jobs as failed. + if: ${{ cancelled() }} + run: exit 1