Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ashm data frames have inconsistent chr prefixing #11

Open
lkhilton opened this issue Jun 14, 2023 · 1 comment
Open

ashm data frames have inconsistent chr prefixing #11

lkhilton opened this issue Jun 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lkhilton
Copy link

The data frames stored under GAMBLR.data::somatic_hypermutation_locations_GRCh37_v* have chr prefixing in the chromosome column, which creates a lot of extra work to handle in most instances. Also the column names could be streamlined substantially.

@Kdreval
Copy link
Contributor

Kdreval commented Jul 11, 2023

I kept the chr prefixing and column names in this package to reproduce what was in the original GAMBLR bundled data. I can easily strip the prefix and update the column names - but not sure how many issues it will cause for the existing codebase in the current functions that (probably?) expect this behavior. I think to address this issue we need first a reproducible set of tests that can indicate whether or not there are issues with existing functions, and this issue will be an excellent use case for the testing approach. I will work on bundling the data with GAMBLR so we can start the work of developing the test suite.

@mattssca mattssca added the enhancement New feature or request label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants