Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the visual style for <code> tag in KB articles #5037

Open
dannycolin opened this issue Feb 23, 2022 · 4 comments
Open

Enhance the visual style for <code> tag in KB articles #5037

dannycolin opened this issue Feb 23, 2022 · 4 comments

Comments

@dannycolin
Copy link

Step to reproduce

  1. Create or edit a KB article
  2. Add a <code> tag
  3. Preview the content

Actual behavior

The content in between <code> use a monospace font.

image

Expected behavior

The content should still use a monospace font but it should also have a border and a different background-color around it to clearly delimit it.

@Rexogamer
Copy link
Contributor

Rexogamer commented Sep 3, 2022

I've made a basic mockup using DevTools, but I have one question - does the text look better unbolded
image

or should it remain as-is?

image

For reference, here's the CSS:

code {
  font-size: .875em;
  background: var(--color-light-gray-03);
  border: 2px solid var(--color-light-gray-05);
  border-radius: 3px;
  padding: 1px;
}

@dannycolin
Copy link
Author

does the text look better unbolded

It does look better without the bold styling.

@Rexogamer
Copy link
Contributor

It looks like the (S)CSS for this is here - I'm not sure if other Mozilla projects using Protocol would have any objections to this change, so it might be worth opening an issue there

@Rexogamer
Copy link
Contributor

Update: it is, in fact, within Kitsune

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🗄 backlog
Development

No branches or pull requests

3 participants
@dannycolin @Rexogamer and others