Skip to content
This repository has been archived by the owner on Sep 14, 2019. It is now read-only.

Move GPG tests out of client.NewClient #374

Open
ameihm0912 opened this issue Jul 26, 2017 · 4 comments
Open

Move GPG tests out of client.NewClient #374

ameihm0912 opened this issue Jul 26, 2017 · 4 comments

Comments

@ameihm0912
Copy link

NewClient currently runs a test to see if it can obtain a signed token to validate the key ring is accessible.

There are some cases where client functions are used where the PGP signature is not actually required. An example is a scenario where you want to generate and display a JSON action (mig-cmd's -p option).

A separate function to test the GPG integration would be useful as it could be called explicitly prior to entering any code where signing will be occurring, and we just wouldn't test the integration when signing is not required.

@scriptonist
Copy link

Hi. I would love to take this issue. I'm a beginner and pretty new to the mig project.

@Bubblemelon
Copy link

Bubblemelon commented Oct 23, 2017

Hello @scriptonist, did you get to resolve this issue?

@scriptonist
Copy link

I'm very sorry. I totally forgot about this since I was not assigned.

@vbmade2000
Copy link
Contributor

@ameihm0912 I think this issue can be closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants