Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timer-3.2 test failure when building with tcl on osx #282

Closed
fgaz opened this issue Sep 13, 2023 · 3 comments
Closed

timer-3.2 test failure when building with tcl on osx #282

fgaz opened this issue Sep 13, 2023 · 3 comments

Comments

@fgaz
Copy link

fgaz commented Sep 13, 2023

When jimtcl is built with tcl on osx, this test fails:

timer-3.2 ERR TimerHandlerEventProc procedure: multiple timers
/private/tmp/nix-build-jimtcl-0.82.drv-0/source/tests/timer.test:61:Error test failure
Expected: {80 {80 240} {80 240 400}}
Got     : {80 {80 240 400} {80 240 400}}

This does not happen on linux or when bootstrapping with jim.

Initially discovered here: NixOS/nixpkgs#253638 (comment)

@msteveb
Copy link
Owner

msteveb commented Sep 13, 2023

Thanks for the report. This is not a bug in JimTcl. It is simply that these timer tests are a bit fragile if running on a VM or an overloaded system. I suggest just disabling timer.test.

BTW, I have some comments on the nixos configuration of JimTcl. Where is the best place to provide that feedback?

msteveb added a commit that referenced this issue Sep 13, 2023
On systems where we aren't getting enough cpu time.
Heuristic check, but probably good enough in practice.

Fixes #282

Signed-off-by: Steve Bennett <steveb@workware.net.au>
@msteveb
Copy link
Owner

msteveb commented Sep 13, 2023

See #283
This may help

@fgaz
Copy link
Author

fgaz commented Sep 14, 2023

Thanks, we'll try applying that patch!

BTW, I have some comments on the nixos configuration of JimTcl. Where is the best place to provide that feedback?

You can open an issue here and tag me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants