Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users installing to an existing directory even if they acknowledge the danger #78

Open
lazka opened this issue Feb 2, 2024 · 0 comments

Comments

@lazka
Copy link
Member

lazka commented Feb 2, 2024

If installing to an existing install it shows:

image

But if installing to an existing random directory it shows:

image

While there is a warning, I doubt there is a valid reason for anyone to click "Yes" there. The chance of the user not reading the message and a future uninstall deleting unrelated files is just too big.

The qt installer doesn't have a setting to make this stricter sadly: https://github.com/qtproject/installer-framework/blob/047bb926705b8fa290d2a276ab0869b2afaa96f9/src/libs/installer/packagemanagercore.cpp#L1134

But we could look into if we can abort the installer after that even if the user selected yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant