-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7.1 compatibility #62
Comments
Are you able to send a PR on any of those items that pass the tests? |
Sorry, PR stands for? |
My apologies. Pull Request - when you fork a repo, make changes, and submit them for review. |
Hmm, I know the reason of one failure: Disallow the ASCII delete control character in identifiers If you replace line 18 in spyc.yml with the following one it stops failing: |
@rayfoss it's about php7.1 not php7.0 - related to types, conversion and things like this php7.1 is much stricter than php7.0 or php5.6, we had to change all |
Hey,
I was doing some tests of the library with php 7.1 and there are 4 tests failing:
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
'NewLine' => '\n'
@@ @@
'float_test_with_quotes' => '1.0'
'a_really_large_number' => '11579208923731619542357098500...639936'
'int array' => Array (...)
'array on several lines' => Array (...)
'morelesskey' => ''
'array_of_zero' => Array (...)
'sophisticated_array_of_zero' => Array (...)
'switches' => Array (...)
'empty_sequence' => Array ()
'empty_hash' => Array ()
'special_characters' => '[{]]{{]]'
'asterisks' => '*'
'empty_key' => Array (...)
'trailing_colon' => 'foo:'
'multiline_items' => Array (...)
'many_lines' => 'A quick\nfox\n\n\njumped\nover\n\n\n\n...\n\n\ndog'
'werte' => Array (...)
'noindent_records' => ''
1041 => Array (...)
1042 => Array (...)
'a:1' => Array (...)
'a:2' => Array (...)
'a:3' => Array (...)
'complex_unquoted_key' => Array (...)
'array with commas' => Array (...)
'invoice' => Array (...)
'quotes' => Array (...)
'endloop' => 'Does this line in the end ind... loop?'
)
/Users/gene/Work/oDesk/Vena/vena/vendor/mustangostang/spyc/tests/DumpTest.php:24
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
'SmallFloat' => 0.7
'
@@ @@
'float_test_with_quotes' => '1.0'
'a_really_large_number' => '11579208923731619542357098500...639936'
'int array' => Array (...)
'array on several lines' => Array (...)
'morelesskey' => ''
'array_of_zero' => Array (...)
'sophisticated_array_of_zero' => Array (...)
'switches' => Array (...)
'empty_sequence' => Array ()
'empty_hash' => Array ()
'special_characters' => '[{]]{{]]'
'asterisks' => '*'
'empty_key' => Array (...)
'trailing_colon' => 'foo:'
'multiline_items' => Array (...)
'many_lines' => 'A quick\nfox\n\n\njumped\nover\n\n\n\n...\n\n\ndog'
'werte' => Array (...)
'noindent_records' => ''
1041 => Array (...)
1042 => Array (...)
'a:1' => Array (...)
'a:2' => Array (...)
'a:3' => Array (...)
'complex_unquoted_key' => Array (...)
'array with commas' => Array (...)
'invoice' => Array (...)
'quotes' => Array (...)
'endloop' => 'Does this line in the end ind... loop?'
)
/Users/gene/Work/oDesk/Vena/vena/vendor/mustangostang/spyc/tests/DumpTest.php:35
Failed asserting that '0xf3' is identical to 243.
/Users/gene/Work/oDesk/Vena/vena/vendor/mustangostang/spyc/tests/ParseTest.php:47
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
)
/Users/gene/Work/oDesk/Vena/vena/vendor/mustangostang/spyc/tests/RoundTripTest.php:38
FAILURES!
Tests: 132, Assertions: 135, Failures: 4.
The text was updated successfully, but these errors were encountered: