From 4b879fb5a07369cafb973ae2f3bf473e5531cfa1 Mon Sep 17 00:00:00 2001
From: Edie Lemoine <edie@myparcel.nl>
Date: Fri, 4 Oct 2024 13:22:06 +0200
Subject: [PATCH] fix(carriers): remove return option for dhlforyou

---
 config/platform/myparcel.php                                   | 2 +-
 ...m_external_identifier_with_data_set_default_carrier__1.json | 2 +-
 ...ernal_identifier_with_data_set_subscription_carrier__1.json | 2 +-
 ..._it_instantiates_carriers_from_name_with_(myparcel)__1.json | 2 +-
 ...export_age_check__data_set_various_delivery_options__1.json | 1 -
 ...export_insurance__data_set_various_delivery_options__1.json | 1 -
 ...ort_large_format__data_set_various_delivery_options__1.json | 1 -
 ...t_only_recipient__data_set_various_delivery_options__1.json | 1 -
 ...ata_set_export_return__data_set_carrier_dhl_for_you__1.json | 3 +--
 ...et_export_return__data_set_various_delivery_options__1.json | 1 -
 ...export_signature__data_set_various_delivery_options__1.json | 1 -
 ...export_age_check__data_set_various_delivery_options__1.json | 2 +-
 ...export_insurance__data_set_various_delivery_options__1.json | 2 +-
 ...ort_large_format__data_set_various_delivery_options__1.json | 2 +-
 ...t_only_recipient__data_set_various_delivery_options__1.json | 2 +-
 ...ata_set_export_return__data_set_carrier_dhl_for_you__1.json | 2 +-
 ...et_export_return__data_set_various_delivery_options__1.json | 2 +-
 ...export_signature__data_set_various_delivery_options__1.json | 2 +-
 ...atformManagerTest__it_gets_carriers_with_(myparcel)__1.json | 2 +-
 ..._retrieves_config_for_each_platform_with_(myparcel)__1.json | 2 +-
 20 files changed, 14 insertions(+), 21 deletions(-)

diff --git a/config/platform/myparcel.php b/config/platform/myparcel.php
index 11c817c4b..9b7ccec33 100644
--- a/config/platform/myparcel.php
+++ b/config/platform/myparcel.php
@@ -119,7 +119,7 @@
                     'ageCheck'         => true,
                     'largeFormat'      => false,
                     'onlyRecipient'    => true,
-                    'return'           => true,
+                    'return'           => false,
                     'sameDayDelivery'  => true,
                     'signature'        => true,
                     'saturdayDelivery' => true,
diff --git a/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_default_carrier__1.json b/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_default_carrier__1.json
index a326e4984..c3df6cbe0 100644
--- a/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_default_carrier__1.json
+++ b/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_default_carrier__1.json
@@ -18,7 +18,7 @@
       "ageCheck": true,
       "largeFormat": false,
       "onlyRecipient": true,
-      "return": true,
+      "return": false,
       "sameDayDelivery": true,
       "signature": true,
       "saturdayDelivery": true,
diff --git a/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_subscription_carrier__1.json b/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_subscription_carrier__1.json
index 20be27124..3baf3080b 100644
--- a/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_subscription_carrier__1.json
+++ b/tests/__snapshots__/CarrierTest__it_instantiates_carrier_from_external_identifier_with_data_set_subscription_carrier__1.json
@@ -19,7 +19,7 @@
       "ageCheck": true,
       "largeFormat": false,
       "onlyRecipient": true,
-      "return": true,
+      "return": false,
       "sameDayDelivery": true,
       "signature": true,
       "saturdayDelivery": true,
diff --git a/tests/__snapshots__/CarrierTest__it_instantiates_carriers_from_name_with_(myparcel)__1.json b/tests/__snapshots__/CarrierTest__it_instantiates_carriers_from_name_with_(myparcel)__1.json
index 22b4f5589..53e10a12d 100644
--- a/tests/__snapshots__/CarrierTest__it_instantiates_carriers_from_name_with_(myparcel)__1.json
+++ b/tests/__snapshots__/CarrierTest__it_instantiates_carriers_from_name_with_(myparcel)__1.json
@@ -107,7 +107,7 @@
         "ageCheck": true,
         "largeFormat": false,
         "onlyRecipient": true,
-        "return": true,
+        "return": false,
         "sameDayDelivery": true,
         "signature": true,
         "saturdayDelivery": true,
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_age_check__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_age_check__data_set_various_delivery_options__1.json
index e76f02c99..78ee0dd34 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_age_check__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_age_check__data_set_various_delivery_options__1.json
@@ -58,7 +58,6 @@
           "delivery_type": 2,
           "age_check": 1,
           "hide_sender": 1,
-          "return": 1,
           "signature": 1
         },
         "physical_properties": {
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_insurance__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_insurance__data_set_various_delivery_options__1.json
index e76f02c99..78ee0dd34 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_insurance__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_insurance__data_set_various_delivery_options__1.json
@@ -58,7 +58,6 @@
           "delivery_type": 2,
           "age_check": 1,
           "hide_sender": 1,
-          "return": 1,
           "signature": 1
         },
         "physical_properties": {
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_large_format__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_large_format__data_set_various_delivery_options__1.json
index 7fa8288ae..c7f55cea2 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_large_format__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_large_format__data_set_various_delivery_options__1.json
@@ -59,7 +59,6 @@
           "delivery_type": 2,
           "age_check": 1,
           "hide_sender": 1,
-          "return": 1,
           "signature": 1
         },
         "physical_properties": {
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_only_recipient__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_only_recipient__data_set_various_delivery_options__1.json
index e76f02c99..78ee0dd34 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_only_recipient__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_only_recipient__data_set_various_delivery_options__1.json
@@ -58,7 +58,6 @@
           "delivery_type": 2,
           "age_check": 1,
           "hide_sender": 1,
-          "return": 1,
           "signature": 1
         },
         "physical_properties": {
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_carrier_dhl_for_you__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_carrier_dhl_for_you__1.json
index eb9e74ee7..0f32bf2d0 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_carrier_dhl_for_you__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_carrier_dhl_for_you__1.json
@@ -9,8 +9,7 @@
         },
         "options": {
           "package_type": 1,
-          "delivery_type": 2,
-          "return": 1
+          "delivery_type": 2
         },
         "physical_properties": {
           "weight": 0
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_various_delivery_options__1.json
index ad6152fec..c3b951032 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_return__data_set_various_delivery_options__1.json
@@ -59,7 +59,6 @@
           "delivery_type": 2,
           "age_check": 1,
           "hide_sender": 1,
-          "return": 1,
           "signature": 1
         },
         "physical_properties": {
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_signature__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_signature__data_set_various_delivery_options__1.json
index e76f02c99..78ee0dd34 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_signature__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_default__data_set_export_signature__data_set_various_delivery_options__1.json
@@ -58,7 +58,6 @@
           "delivery_type": 2,
           "age_check": 1,
           "hide_sender": 1,
-          "return": 1,
           "signature": 1
         },
         "physical_properties": {
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_age_check__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_age_check__data_set_various_delivery_options__1.json
index 733e5a3ea..164490296 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_age_check__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_age_check__data_set_various_delivery_options__1.json
@@ -173,7 +173,7 @@
             "large_format": 0,
             "only_recipient": 0,
             "package_type": 1,
-            "return": 1,
+            "return": 0,
             "same_day_delivery": 0,
             "signature": 1
           },
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_insurance__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_insurance__data_set_various_delivery_options__1.json
index 733e5a3ea..164490296 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_insurance__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_insurance__data_set_various_delivery_options__1.json
@@ -173,7 +173,7 @@
             "large_format": 0,
             "only_recipient": 0,
             "package_type": 1,
-            "return": 1,
+            "return": 0,
             "same_day_delivery": 0,
             "signature": 1
           },
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_large_format__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_large_format__data_set_various_delivery_options__1.json
index 5bbcba2f5..fb6b6d25a 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_large_format__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_large_format__data_set_various_delivery_options__1.json
@@ -173,7 +173,7 @@
             "large_format": 0,
             "only_recipient": 0,
             "package_type": 1,
-            "return": 1,
+            "return": 0,
             "same_day_delivery": 0,
             "signature": 1
           },
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_only_recipient__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_only_recipient__data_set_various_delivery_options__1.json
index 733e5a3ea..164490296 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_only_recipient__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_only_recipient__data_set_various_delivery_options__1.json
@@ -173,7 +173,7 @@
             "large_format": 0,
             "only_recipient": 0,
             "package_type": 1,
-            "return": 1,
+            "return": 0,
             "same_day_delivery": 0,
             "signature": 1
           },
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_carrier_dhl_for_you__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_carrier_dhl_for_you__1.json
index 407586abc..1105f10c5 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_carrier_dhl_for_you__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_carrier_dhl_for_you__1.json
@@ -46,7 +46,7 @@
             "large_format": 0,
             "only_recipient": 0,
             "package_type": 1,
-            "return": 1,
+            "return": 0,
             "same_day_delivery": 0,
             "signature": 0
           },
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_various_delivery_options__1.json
index c9b424404..abedbb9e9 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_return__data_set_various_delivery_options__1.json
@@ -173,7 +173,7 @@
             "large_format": 0,
             "only_recipient": 0,
             "package_type": 1,
-            "return": 1,
+            "return": 0,
             "same_day_delivery": 0,
             "signature": 1
           },
diff --git a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_signature__data_set_various_delivery_options__1.json b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_signature__data_set_various_delivery_options__1.json
index 733e5a3ea..164490296 100644
--- a/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_signature__data_set_various_delivery_options__1.json
+++ b/tests/__snapshots__/ExportOrderActionTest__it_exports_order_with_data_set_order_mode__data_set_export_signature__data_set_various_delivery_options__1.json
@@ -173,7 +173,7 @@
             "large_format": 0,
             "only_recipient": 0,
             "package_type": 1,
-            "return": 1,
+            "return": 0,
             "same_day_delivery": 0,
             "signature": 1
           },
diff --git a/tests/__snapshots__/PlatformManagerTest__it_gets_carriers_with_(myparcel)__1.json b/tests/__snapshots__/PlatformManagerTest__it_gets_carriers_with_(myparcel)__1.json
index 22b4f5589..53e10a12d 100644
--- a/tests/__snapshots__/PlatformManagerTest__it_gets_carriers_with_(myparcel)__1.json
+++ b/tests/__snapshots__/PlatformManagerTest__it_gets_carriers_with_(myparcel)__1.json
@@ -107,7 +107,7 @@
         "ageCheck": true,
         "largeFormat": false,
         "onlyRecipient": true,
-        "return": true,
+        "return": false,
         "sameDayDelivery": true,
         "signature": true,
         "saturdayDelivery": true,
diff --git a/tests/__snapshots__/PlatformManagerTest__it_retrieves_config_for_each_platform_with_(myparcel)__1.json b/tests/__snapshots__/PlatformManagerTest__it_retrieves_config_for_each_platform_with_(myparcel)__1.json
index ee7c7601b..c072a3015 100644
--- a/tests/__snapshots__/PlatformManagerTest__it_retrieves_config_for_each_platform_with_(myparcel)__1.json
+++ b/tests/__snapshots__/PlatformManagerTest__it_retrieves_config_for_each_platform_with_(myparcel)__1.json
@@ -57,7 +57,7 @@
           "ageCheck": true,
           "largeFormat": false,
           "onlyRecipient": true,
-          "return": true,
+          "return": false,
           "sameDayDelivery": true,
           "signature": true,
           "saturdayDelivery": true,