Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Linking to a web page outside of the project opens in same webview #2

Open
nabilfreeman opened this issue Jun 21, 2015 · 5 comments
Open

Comments

@nabilfreeman
Copy link
Owner

This is a problem as there are no browser controls.

Ideal solution would be to instruct the webview to open non-local links or whatever in Safari... don't know how to do this yet.

@jstart
Copy link

jstart commented Jun 22, 2015

Probably would want to just check if the URL is external, then either use UIApplication.openURL or SFSafariViewController. Would you accept a PR that added a configurable way to use one of these two approaches?

@nabilfreeman
Copy link
Owner Author

@jstart absolutely!

@PatrickBK
Copy link

Any news on this issue? Do external links, not on the defined domain, open in Safari yet?

@nabilfreeman
Copy link
Owner Author

hey @PatrickBK, not yet! i don't have time to add it as my day job isn't currently iOS stuff.

If somebody would like to patch this, please feel free 😁 ( @jstart ? )

@PatrickBK
Copy link

Hi @nabilfreeman, I understand and thanks for putting it out there as is :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants