Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use semi-expiration in Manage Names tab #533

Open
JeremyRand opened this issue Jan 17, 2023 · 1 comment
Open

Use semi-expiration in Manage Names tab #533

JeremyRand opened this issue Jan 17, 2023 · 1 comment
Labels
enhancement qt

Comments

@JeremyRand
Copy link
Member

Is your feature request related to a problem? Please describe.

The Manage Names tab shows a countdown to expiry. This may give the user the impression that their name does not need renewal yet, when in reality it does due to semi-expiration.

Describe the solution you'd like

Switch the Manage Names tab to show a countdown to semi-expiry instead.

Describe alternatives you've considered

N/A.

Additional context

N/A.
@JeremyRand
Copy link
Member Author

Blocked by #532

domob1812 pushed a commit that referenced this issue Feb 16, 2024
@hebasto
Merge bitcoin-core/gui#553: Change address / amount error background
7b39702 
fe7c81e qt: change QLineEdit error background (w0xlt)

Pull request description:

  This PR proposes a small change in QLineEdit when there is an error in the input.

  master |
  --- |
  ![image](https://user-images.githubusercontent.com/94266259/154762427-b816267e-ec70-4a8f-a7fb-1317ebacf1a4.png)

  PR |
  --- |
  ![image](https://user-images.githubusercontent.com/94266259/154761933-15eb3d81-ca81-4498-b8ec-cf1139ae2f8a.png) |

  This also shows good results when combined with other open PRs.

  #537 |
  --- |
  ![image](https://user-images.githubusercontent.com/94266259/154763411-6266a283-2d8a-4365-b3f2-a5cb545e773e.png)

  #533 |
  --- |
  ![image](https://user-images.githubusercontent.com/94266259/154765638-f38b13d6-a4f8-4b46-a470-f882668239f3.png) |

ACKs for top commit:
  GBKS:
    ACK fe7c81e
  jarolrod:
    ACK fe7c81e
  shaavan:
    ACK fe7c81e

Tree-SHA512: eccc53f42d11291944ccb96efdbe460cb10af857f1d4fa9b5348ddcb0796c82faf1cdad9040aae7a25c5d8f4007d6284eba868d7af14acf56280f6acae170b91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement qt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRand