Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox&Web: Unchecked checkbox&radio are hard to see with dark variant #123

Open
nana-4 opened this issue Jun 6, 2017 · 9 comments
Open

Comments

@nana-4
Copy link
Owner

nana-4 commented Jun 6, 2017

Screenshot from #75
image

Dark variants using translucent white rgba(255, 255, 255, 0.7) for check and radio, so they are hardly visible on the bright background.

This affects Firefox, Epiphany, etc.

@nana-4 nana-4 changed the title Unchecked checkbox/radio are hard to see in Firefox/Epiphany with dark variants Unchecked checkbox/radio on the web are hard to see with dark variants Jun 6, 2017
@nioncode
Copy link

nioncode commented Mar 11, 2018

In Firefox, I can't distinguish between checked and unchecked checkboxes in the dark variant at all.
In the picture, 'NixOS' is checked, all others are not.
EDIT: looks the same in the light variant, so it is not an issue with the dark variant for me.

2018-03-11-133841_1920x1080_scrot

@nana-4
Copy link
Owner Author

nana-4 commented Mar 11, 2018

@nioncode Hmm, that's strange. Could you tell me the following?

  • What is the version of Firefox?
  • (If you know) what is the version of Materia?
  • How did you get Materia?
  • Have you customized Materia by yourself?
  • What is your distro and version?

@nioncode
Copy link

Firefox v58.0.2
Materia v20180311 (initially v20180110, but I just fetched the latest version to check)

I'm on NixOS 17.09.3146.084445b8f38 and installed Materia through the nix packaging system.
Except of patching files to make things work on NixOS, there are no customizations.

How can I help debug this?

@nana-4
Copy link
Owner Author

nana-4 commented Mar 11, 2018

Thanks!

I couldn't reproduce it on Fedora 27, Firefox v58.0.2 and latest Materia.

I don't know any details about the nix packaging system or NixOS, but there is a possibility that it's due to a wrong file permission. Please check: #182

@nioncode
Copy link

After having solved the red check boxes in #182, the original problem reported in this issue (barely visible unchecked boxes for the dark theme) is still there.
Do you have any plans for fixing this soonish? That is basically the only thing holding me back from using materia at the moment.

nana-4 added a commit that referenced this issue Mar 19, 2018
regardless of whether the background is bright or dark (#123)
@nana-4
Copy link
Owner Author

nana-4 commented Mar 19, 2018

@nioncode Now I've fixed it for Firefox. :)

image

(This problem still remains in Epiphany, etc.)

@nioncode
Copy link

Sweet! Unfortunately, I liked the red/pink color scheme more.
I saw there is a customization tool in place. Would you mind providing different color schemes upstream so I don't have to build everything locally but can use my distro's packages?

@nana-4
Copy link
Owner Author

nana-4 commented Mar 21, 2018

Since I got many dissatisfied opinions from users about Pink accent color, I changed it to Teal.

Would you mind providing different color schemes upstream

I'm not considering it for now because it is hard to maintain many variants. I hope that getting used to the color will change your mind, but anyway, please, post your opinion to #220 for future decision making. :)

capi1O pushed a commit to capi1O/materia-theme that referenced this issue Apr 20, 2018
@nana-4 nana-4 changed the title Unchecked checkbox/radio on the web are hard to see with dark variants Firefox&Web: Unchecked checkbox&radio are hard to see with dark variant Nov 12, 2018
@protesilaos
Copy link

Just to add to this issue, that Epiphany (GNOME Web) distorts checkboxes while using the dark variants of Materia.

In the image below, the last line of the post contains a checkbox. It is invisible. It should be an unchecked box.

epiphany_checkboxes_materia-dark

The following image shows the same web page in Epiphany while using another custom theme: Arc Dark. The unchecked box is visible.

epiphany_checkboxes_arc-dark

In my experience this only concerns Epiphany and only the dark versions of Materia. For example, Firefox renders the same elements as expected:

firefox_checkboxes_materia-dark


I encountered this issue while using Debian stable ('buster').

Package versions:

  • materia-gtk-theme (20190201-1)
  • epiphany-browser (3.32.1.2-3~deb10u1)
  • firefox-esr (68.2.0esr-1~deb10u1)
  • arc-theme (20190213-1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants