Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for Jetstream domain #138

Open
TarasLykhenko opened this issue Aug 30, 2023 · 2 comments
Open

Feature request: Add support for Jetstream domain #138

TarasLykhenko opened this issue Aug 30, 2023 · 2 comments
Assignees
Labels
proposal Enhancement idea or proposal

Comments

@TarasLykhenko
Copy link

What motivated this proposal?

I am trying to implement Jetstream with leaf nodes following a spoke/hub architecture, but NACK currently does not support specifying the Jetstream domain in which the stream should be created. https://github.com/nats-io/jetstream-leaf-nodes-demo/tree/main

What is the proposed change?

I am proposing to add a new field to the Stream and Consumer called jsDomain that overwrites the default jetstream domain.

apiVersion: jetstream.nats.io/v1beta2
kind: Stream
metadata:
  name: mystream
spec:
  name: mystream
  subjects: ["orders.*"]
  jsDomain: "spoke-1"
  storage: memory
  maxAge: 1h

Moreover, to add the ability to set the default jsDomain that is used when no domain is specified in the CR.

Who benefits from this change?

No response

What alternatives have you evaluated?

No response

@TarasLykhenko TarasLykhenko added the proposal Enhancement idea or proposal label Aug 30, 2023
@gedw99
Copy link

gedw99 commented Sep 13, 2023

I think I need this too.

https://github.com/ServiceWeaver/weaver allows direct CRD control and I embed NATS leaves.

Weaver runs on GCP, EKS, k8 on premise and bare metal without any docker.

cc @bruth

@Jarema
Copy link
Member

Jarema commented Nov 10, 2023

We will look into this.
As domain is part of the jetstream context, not consumer or stream api calls, it might need some small refactor.

@Jarema Jarema self-assigned this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Enhancement idea or proposal
Projects
None yet
Development

No branches or pull requests

3 participants