Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a strategy for each song that finds the artist address #324

Open
TimDaub opened this issue Oct 19, 2022 · 8 comments
Open

implement a strategy for each song that finds the artist address #324

TimDaub opened this issue Oct 19, 2022 · 8 comments
Assignees

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Oct 19, 2022

  • related: EPIC: Getting token holder information from neume data #321
  • for each music NFT find its artist
  • in some cases, that may be the person that also minted the NFT initially
  • In some cases we'll probably have to figure out the contract semantics to understand which addresses represent the artists
@neatonk
Copy link
Member

neatonk commented Oct 19, 2022

For zora drops contracts the creator address could be used.

https://github.com/neatonk/strategies/blob/021e33808b29fa15ca9961d0a3e6fc6a06f63689/src/strategies/zora-drops-filter-contracts/transformer.mjs#L27-L31

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 20, 2022

Here's what @reimertz wants:

minter whoever minted the nft
artist artist who created the song / track
owner who is the current owner of said nft

@TimDaub TimDaub self-assigned this Oct 20, 2022
@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 20, 2022

Screenshot 2022-10-20 at 15 00 39

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 20, 2022

For Zora (catalog v1), the transaction sender of the mint transaction is likely the artist.

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 20, 2022

For zora artworks usually the minter is the artist unless there are contracts interacting with the zora contract. So actually we should examine catalog v1 specifically.

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 20, 2022

  • added transactionHash to call-tokenuri: 57e4f2c
  • 2b238f0 separated getting transaction receipts from get-minter

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 20, 2022

we're now requiring an artist.address property in /schema: neume-network/schema@db192d2

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 21, 2022

For Zora (catalog v1), the transaction sender of the mint transaction is likely the artist.

this was confirmed to me by a catalog contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants