Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call-tokenuri must fail when resultKey isn't defined #335

Open
TimDaub opened this issue Oct 24, 2022 · 0 comments
Open

call-tokenuri must fail when resultKey isn't defined #335

TimDaub opened this issue Oct 24, 2022 · 0 comments

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Oct 24, 2022

  • strategies/src/strategies/call-tokenuri/transformer.mjs

    Line 20 in 57e4f2c

    function onLine(line, resultKey) {
  • it makes no sense that call-tokenuri runs without resultKey being defined as nobody would expect a result at a property titled "undefined"
  • So instead the strategy should error entirely and refuse to run

//cc @il3ven
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimDaub