Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring a deleted file in a deleted subfolder causes unexpected behaviour #1257

Closed
maxemann96 opened this issue Jan 31, 2021 · 6 comments
Closed
Labels
1. to develop Issues that are ready for development bug feature: trashbin Items related to the trashbin feature integration low low priority needs info

Comments

@maxemann96
Copy link

Actual behaviour:
Restoring a deleted file laying in an also deleted folder restores the file into the root of the groupfolder.

Expected behaviour:
The nested directory structure and the file should be restored (with the original permissions of the substructure).

To reproduce:

  1. Create a group folder /groupfolder
  2. Create a folder /groupfolder/sub with one file /groupfolder/sub/file
  3. Delete the file /groupfolder/sub/file
  4. Delete the folder /groupfolder/sub
  5. Restore the file /groupfolder/sub/file
@pierreozoux pierreozoux added bug low low priority 0. Needs triage Issues that need to be triaged labels Mar 10, 2021
@pierreozoux
Copy link
Member

I just reproduce, and I agree that it is unexpected.

@pierreozoux pierreozoux added 1. to develop Issues that are ready for development and removed 0. Needs triage Issues that need to be triaged labels Mar 11, 2021
@pierreozoux pierreozoux added integration feature: trashbin Items related to the trashbin feature labels Mar 28, 2021
@fschrempf fschrempf changed the title Restoring a deleted file in a nested deleted folder causes unexpected behaviour Restoring a deleted file in a deleted subfolder causes unexpected behaviour Nov 27, 2021
@mejo-
Copy link
Member

mejo- commented Apr 21, 2022

@maxemann96 and @pierreozoux can you still reproduce this bug with latest version of Groupfolder app on Nextcloud 23? I fail to reproduce the issue on Nextcloud 24 RC1 at least. Also, do you use special storage backends?

@pierreozoux
Copy link
Member

We are using minio as a storage backend, but no longer using group folder 🙃

@mejo-
Copy link
Member

mejo- commented Apr 25, 2022

Thanks @pierreozoux, so let's close this issue as non-reproducible for now.

@mejo- mejo- closed this as completed Apr 25, 2022
@maxemann96
Copy link
Author

Hey all, sorry for the very long answer time. This issue still persists. To retest it I created the following structure:

  • Create a group folder /groupfolder
  • Create a sub group folder /groupfolder/subGroupfolder
  • Create a normal folder /groupfolder/subGroupfolder/sub with one file /groupfolder/subGroupfolder/sub/file
  • Delete the file /groupfolder/subGroupfolder/sub/file
  • Delete the folder /groupfolder/subGroupfolder/sub
  • Restore the file /groupfolder/sub/file

Notice that the file is restored to /groupfolder/file. Which I find is very unexpected that the file gets restored into the root groupfolder. Tested on NC 24.0.1 with group folders version 12.0.0.

@jngrb
Copy link
Contributor

jngrb commented Jul 20, 2022

As the bug can still be easily reproduced in our setup, I opened a new issue #2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Issues that are ready for development bug feature: trashbin Items related to the trashbin feature integration low low priority needs info
Projects
None yet
Development

No branches or pull requests

4 participants