Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File versioning broken for groupfolders #1901

Closed
XueSheng-GIT opened this issue Feb 16, 2022 · 6 comments · Fixed by #2047
Closed

File versioning broken for groupfolders #1901

XueSheng-GIT opened this issue Feb 16, 2022 · 6 comments · Fixed by #2047
Labels
0. Needs triage Issues that need to be triaged bug version

Comments

@XueSheng-GIT
Copy link

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Create a groupfolder
  2. Create a file (e.g. "Document-version-test.odt", could also be a markdown file).
  3. Enter some text to the file. Wait a couple of minutes and do another edit.

Expected behaviour

After edit of file, the old (previous) file version shall be saved and available (timestamp of the previous edit).
File versions shall be listed in the order newest (top) to oldest (bottom).

Actual behaviour

After edit of file, a version is created with the current timestamp (instead of the timestamp of the last edit which was done before).
The order of file versions is oldest (top) to newest (bottom).
When creating a file outside of a groupfolder, versions are created as expected (timestamps and order of versions). When moving the file from outside the groupfolder to a groupfolder, versions are lost (same issue?).

Server configuration

Operating system: Ubuntu 20.04

Web server: Apache/2.4.52 (Ubuntu)

Database: mysql Ver 15.1 Distrib 10.3.32-MariaDB

PHP version: 7.4.27

Nextcloud version: 23.0.2

Group folders version: 11.1.2

Updated from an older Nextcloud/ownCloud or fresh install: originally owncloud

Where did you install Nextcloud from: official homepage

Are you using external storage, if yes which one: local

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 97.0

Operating system: Ubuntu 20.04

Logs

No errors are logged!

@XueSheng-GIT XueSheng-GIT added 0. Needs triage Issues that need to be triaged bug labels Feb 16, 2022
@XueSheng-GIT
Copy link
Author

before updrading the version app was disabled and i got this error when I updated do version 23.0.2:

When I enabled the version app, this error disappeared

Thanks for your comment, but I don't get the relation to the issue described in this bug report!?
Did you try to reproduce the steps mentioned in the initial report?

@XueSheng-GIT
Copy link
Author

Thanks for the merged pull. After testing it does only fix half of this issue.
First part was about wrong timestamp of shown versions (which is not fixed yet).
Second about order of versions (which is fixed now).

More in detail about first part of the issue:
File versioning in groupfolders:

  1. Create a file (initial version)
  2. do a change after a day
  3. The old version (initial version) is shown with current timestamp of edit, instead of the timestamp of the initial version (which it refers to).

Doing the same outside if a groupfolder:

  1. Create a file (initial version)
  2. do a change after a day
  3. The old version (initial version) is shown with timestamp of initial version (as expected)

Hope that explanation is understandable. If not, just let me know.

@XueSheng-GIT
Copy link
Author

@juliushaertl should I create a new issue about that missing first part described? Or must this issue be reopened?

@juliusknorr
Copy link
Member

Yes, a separate one would be appreciated, sorry I missed that when reading through the ticket.

@XueSheng-GIT
Copy link
Author

Yes, a separate one would be appreciated, sorry I missed that when reading through the ticket.

Separate issue created: #2055

@natoponen
Copy link

Hello, @juliushaertl the same issue affects me. When are you planning to make a release with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Issues that need to be triaged bug version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants