Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Imperial BMI Calculation with anything but "lb" as weight unit #151

Open
Firedorange717 opened this issue Mar 21, 2023 · 0 comments

Comments

@Firedorange717
Copy link

I use lbs as a weight unit since I am in America, which means I had to change the "Unit for Weight" field in the settings. I was startled to see that the BMI was calculated as being class III Obese which is not right in the slightest. After looking around through the code the problem appears to be in src/modules/weight/mixinBmi.js, it is looking for the weight unit to be "lb" not lbs which unless someone weights one pound is not quite right. If it is not "lb" it trys to calculate the BMI in Metric units which is why it is so off.

Perhaps as a fix have the Unit for Weight field be a dropdown with two options one for metric and one for imperial, that way no invalid values get passed through.

Thanks! I love the app its super useful.

Screenshot 2023-03-21 at 10 00 07 AM

Screenshot 2023-03-21 at 9 59 56 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant