From 175c1166a1f4ff17ef36bc0e6fc70a6374bf342e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 11 Sep 2023 05:26:20 +0000 Subject: [PATCH 1/2] Build(deps): Bump com.diffplug.spotless from 6.19.0 to 6.21.0 Bumps com.diffplug.spotless from 6.19.0 to 6.21.0. --- updated-dependencies: - dependency-name: com.diffplug.spotless dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- News-Android-App/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/News-Android-App/build.gradle b/News-Android-App/build.gradle index 8fef90e4c..621c42b0e 100644 --- a/News-Android-App/build.gradle +++ b/News-Android-App/build.gradle @@ -4,7 +4,7 @@ plugins { id 'kotlin-kapt' id 'com.google.devtools.ksp' id 'io.gitlab.arturbosch.detekt' version "1.23.0" - id "com.diffplug.spotless" version "6.19.0" + id "com.diffplug.spotless" version "6.21.0" } android { From b794dabe76665398b5a39cce3f78484b7aa0133c Mon Sep 17 00:00:00 2001 From: Marcus Nilsson Date: Mon, 11 Sep 2023 17:12:05 +0200 Subject: [PATCH 2/2] Move "Show only unread articles" to the toolbar This patch moves "Show only unread articles" to the toolbar, inside the three dots as discussed in #1026 Signed-off-by: Marcus Nilsson --- .../NewsReaderListActivity.java | 28 ++++++++++++++++++- .../src/main/res/menu/news_reader.xml | 7 +++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java index ab5b5524c..dd9b1f7c0 100644 --- a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java +++ b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/NewsReaderListActivity.java @@ -140,8 +140,11 @@ public class NewsReaderListActivity extends PodcastFragmentActivity implements public static HashSet stayUnreadItems = new HashSet<>(); + private MenuItem menuItemOnlyUnread; private MenuItem menuItemDownloadMoreItems; + private Long currentFolderId; + @VisibleForTesting(otherwise = PROTECTED) public ActivityNewsreaderBinding binding; @@ -671,19 +674,31 @@ private NewsReaderDetailFragment updateDetailFragment(long id, Boolean folder, L Long folderId; String title = null; + if (menuItemOnlyUnread != null) { + menuItemOnlyUnread.setVisible(true); + } + if(!folder) { + currentFolderId = null; feedId = id; folderId = optional_folder_id; title = dbConn.getFeedById(id).getFeedTitle(); } else { + currentFolderId = id; folderId = id; int idFolder = (int) id; if(idFolder >= 0) { title = dbConn.getFolderById(id).getLabel(); } else if(idFolder == -10) { title = getString(R.string.allUnreadFeeds); + if (menuItemOnlyUnread != null) { + menuItemOnlyUnread.setVisible(false); + } } else if(idFolder == -11) { title = getString(R.string.starredFeeds); + if (menuItemOnlyUnread != null) { + menuItemOnlyUnread.setVisible(false); + } } } @@ -789,6 +804,9 @@ public boolean onCreateOptionsMenu(Menu menu) { menuItemDownloadMoreItems.setEnabled(false); MenuItem searchItem = menu.findItem(R.id.menu_search); + menuItemOnlyUnread = menu.findItem(R.id.menu_toggleShowOnlyUnread); + menuItemOnlyUnread.setChecked(mPrefs.getBoolean(SettingsActivity.CB_SHOWONLYUNREAD_STRING, false)); + menuItemOnlyUnread.setVisible(!(currentFolderId == -11 || currentFolderId == -10)); //Set expand listener to close keyboard searchItem.setOnActionExpandListener(new MenuItem.OnActionExpandListener() { @@ -857,7 +875,15 @@ public boolean onOptionsItemSelected(@NonNull MenuItem item) { return true; } else if (itemId == R.id.menu_update) { startSync(); - } else if (itemId == R.id.menu_StartImageCaching) { + } + else if (itemId == R.id.menu_toggleShowOnlyUnread) { + boolean newValue = !mPrefs.getBoolean(SettingsActivity.CB_SHOWONLYUNREAD_STRING, false); + mPrefs.edit().putBoolean(SettingsActivity.CB_SHOWONLYUNREAD_STRING, newValue).commit(); + item.setChecked(newValue); + getSlidingListFragment().reloadAdapter(); + updateCurrentRssView(); + } + else if (itemId == R.id.menu_StartImageCaching) { final DatabaseConnectionOrm dbConn = new DatabaseConnectionOrm(this); long highestItemId = dbConn.getLowestRssItemIdUnread(); diff --git a/News-Android-App/src/main/res/menu/news_reader.xml b/News-Android-App/src/main/res/menu/news_reader.xml index 47afe6a82..dcda008d1 100644 --- a/News-Android-App/src/main/res/menu/news_reader.xml +++ b/News-Android-App/src/main/res/menu/news_reader.xml @@ -40,6 +40,13 @@ android:orderInCategory="97" android:title="@string/menu_markAllAsRead"/> + +