Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starred items are listed backwards #1084

Closed
LinAGKar opened this issue Apr 27, 2022 · 7 comments
Closed

Starred items are listed backwards #1084

LinAGKar opened this issue Apr 27, 2022 · 7 comments
Labels

Comments

@LinAGKar
Copy link

If you set the app to list articles in chronological order, starred items are still showed in reverse chronological order.

@David-Development
Copy link
Member

Thank you for the report - I agree, that the starred items should follow the selected order. I'll fix this in the next update.

@mkanilsson
Copy link
Contributor

mkanilsson commented Sep 6, 2023

Can I give this issue a go or has it already been implemented?

@David-Development
Copy link
Member

David-Development commented Sep 7, 2023

@mkanilsson For sure!

As a bonus - I'm wondering if it makes sense to keep the following feature request in mind: #1026. It could be implemented as an option when the user long presses a feed (when you open the sidebar and long press a feed you get a few extra options/settings for the feed)

When you start on this it might make sense to use the Material 3 branch as a base branch because it is almost done and will be merged soon. This way we probably prevent a lot of merge conflicts in case you make some changes to the UI (#1186).

@mkanilsson
Copy link
Contributor

I could make it 2 PRs, one that fixes this issue and one that implements the feature request.

The feature request might be over my ability since I have 0 experience in android app development, but I'll give it a try!

@David-Development
Copy link
Member

@mkanilsson Sounds great! No worries, let me know if you have any questions!

@David-Development
Copy link
Member

@mkanilsson It probably makes sense to integrate it into the NewsReaderListDialogFragment (Link) in a similar fashion that the Notification Settings are implemented there.
There are more feature requests open that could be added there as well (e.g. #1221).

@mkanilsson
Copy link
Contributor

Moving the discussion over to #1026 as it seems more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants