Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat - Option to disable rich editor button #1819

Open
PowerUser64 opened this issue Jun 15, 2023 · 17 comments
Open

Feat - Option to disable rich editor button #1819

PowerUser64 opened this issue Jun 15, 2023 · 17 comments

Comments

@PowerUser64
Copy link

I think the option to use the rich editor is neat, but I don't see myself needing to use it. Could a setting be added to disable the floating button in the basic editor? Another solution would be to have a setting that moves the button to the ellipsis menu in the upper right. This button bothers me because I often push it by accident and switching back to the basic editor often takes a fair amount of time.

@cheywood
Copy link

Agreed. I also wouldn't have thought it was something people would want to toggle so frequently that it warrants an action button? As in, wouldn't those wanting a rich text editor just leave it enabled all the time?

@PowerUser64
Copy link
Author

It would be far more helpful if this button could instead be used to toggle between edit and view mode or something.

@TheDaAndy
Copy link

TheDaAndy commented Aug 25, 2023

I also don't use it, as I often have Internet disabled/loose connection. But without, the rich text editor fails to load. I also often fall into (server/client version conflicts) but I am the only user on the cloud and the changes happened whil using the rich text editor and switching back when it fails. It makes offline usage uncomfortable.
so I would appreciate to remove the action button as well, as it overlaps often my content.
The reason, why the button pops up while writing is, when removing characters, so the caret jumps one line upwards, the button instantly appears.

@cheywood
Copy link

cheywood commented Aug 26, 2023

It would be far more helpful if this button could instead be used to toggle between edit and view mode or something.

True, although I find the button getting in the way of the text itself (when one is writing at the end of the buffer just above the keyboard), which kind of makes its existence hard to justify.

Edit: typos

@timunrau
Copy link

timunrau commented Sep 3, 2023

Just chiming in - I too have the issues of frequently hitting the rich text editor button by accident and it hiding my content. Both are very disturbing. Maybe it can be in the toolbar or as others have mentioned in the 3 dots menu. Personally I don't use the rich text editor as it messes with my markdown formatting.

@AceJase
Copy link

AceJase commented Jan 15, 2024

Same here - the floating button is an annoyance, I'd imagine even to those who do use the rich editor. I'd very much like to be able to remove that as my notes needs are very basic, which was always the draw to this app. It's a nice feature for some I'm sure, but just having the option to disable rich editing or at least just move that floating button to an option in the menu would be enough. Thank you.

@PowerUser64
Copy link
Author

@stefan-niedermann and/or @AndyScherzinger - what's the current status of this? I see that there are thumbs up's on the original comment from many of the project's devs, and there's an unmerged pull request that fixes this. I don't mean to sound pushy, but I (and others) would really like to see this change implemented, either through merging the pr #1904 or another way. This is an everyday application for most of us (it is for me at least), and this button gets in the way often. I realize that this is an open-source project, you likely have other obligations, and this project is not your first priority. Thank you all for putting this project first where you can, as it has helped many people stop using big tech and enjoy using open-source software!

@AndyScherzinger AndyScherzinger added this to the 4.2.0 milestone Apr 1, 2024
@AndyScherzinger
Copy link
Member

Hi @PowerUser64 - thanks for bringing this to my attention. I checked the PR and worked fine for me. Hence I merged it and am taking care of backporting, so it can be published with the next release.

@AndyScherzinger AndyScherzinger modified the milestones: 4.2.0, 4.2.1 Apr 1, 2024
@PowerUser64
Copy link
Author

Thank you so much!

@timunrau
Copy link

I just excitedly upgraded to 4.2.1 in anticipation of this feature being implemented. But I don't see the option to hide the rich text FAB anywhere. Am I missing something?

@AndyScherzinger
Copy link
Member

Yes, I had to revert it for 4.2.1 since it doesn't fully work unfortunately. There are situation not yet clear to me/us where there is a button and from there onwards you can hit the FAB but nothing happens, so the original PR I tested and merged seems to need some more love to actually be working.

@timunrau
Copy link

Yes, I had to revert it for 4.2.1 since it doesn't fully work unfortunately. There are situation not yet clear to me/us where there is a button and from there onwards you can hit the FAB but nothing happens, so the original PR I tested and merged seems to need some more love to actually be working.

Thanks for the update. Hoping for a solution soon!

@c-o-m-m-a-n-d-e-r-d-a-t-a

Plus one

It gave me a grim smile when I looked up this project that its description is 'distraction free'. Sometimes you simply cannot place the caret because the button is in the way. Um...

Otherwise what a fantastically excellent app which I almost live in for my daily reminders and lists.

Keep up the good work!

@PowerUser64
Copy link
Author

Wouldn't it make more sense to just move the rich editor button to the ellipses menu or settings? I don't think people will need to switch between the two editors so frequently that there needs to be a button in such a prominent place.

@c-o-m-m-a-n-d-e-r-d-a-t-a

For myself at least, I have absolutely no reason to switch to rich edit on my phone. The phone screen's too small for rich editing to make sense anyway. Anything that gets it off the screen, right where you're trying to type, would be a fix.

@juliusknorr
Copy link
Member

Reopening this one instead of nextcloud/notes#1293 as the PR was reverted

@juliusknorr juliusknorr reopened this Jul 12, 2024
@PowerUser64
Copy link
Author

Is there any chance this could be added to the 4.4.0 milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants