From 0f87e0aae66d3f401eb4bbfc7d2c8fc4f80d6afa Mon Sep 17 00:00:00 2001 From: Julien Veyssier Date: Fri, 8 Oct 2021 15:27:15 +0200 Subject: [PATCH] public share link: allow setting permissions on creation, do not always use defaults Signed-off-by: Julien Veyssier --- apps/files_sharing/lib/Controller/ShareAPIController.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/apps/files_sharing/lib/Controller/ShareAPIController.php b/apps/files_sharing/lib/Controller/ShareAPIController.php index fafdb1a64cd1b..87f7ba1f255e1 100644 --- a/apps/files_sharing/lib/Controller/ShareAPIController.php +++ b/apps/files_sharing/lib/Controller/ShareAPIController.php @@ -460,6 +460,7 @@ public function createShare( ): DataResponse { $share = $this->shareManager->newShare(); + $requestPermissions = $permissions; if ($permissions === null) { $permissions = $this->config->getAppValue('core', 'shareapi_default_permissions', Constants::PERMISSION_ALL); } @@ -558,7 +559,10 @@ public function createShare( Constants::PERMISSION_UPDATE | Constants::PERMISSION_DELETE; } else { - $permissions = Constants::PERMISSION_READ; + // do not ignore permissions request param if provided + if ($requestPermissions === null) { + $permissions = Constants::PERMISSION_READ; + } } // TODO: It might make sense to have a dedicated setting to allow/deny converting link shares into federated ones