From 10ac5021aab8433cb6578fe40dc261510fd0bcc4 Mon Sep 17 00:00:00 2001 From: Git'Fellow <12234510+solracsf@users.noreply.github.com> Date: Thu, 27 Jun 2024 08:49:01 +0200 Subject: [PATCH] Rename var to max_filesize Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com> --- core/BackgroundJobs/GenerateMetadataJob.php | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/core/BackgroundJobs/GenerateMetadataJob.php b/core/BackgroundJobs/GenerateMetadataJob.php index d1261ef4037bc..9377a24bce911 100644 --- a/core/BackgroundJobs/GenerateMetadataJob.php +++ b/core/BackgroundJobs/GenerateMetadataJob.php @@ -37,8 +37,8 @@ use Psr\Log\LoggerInterface; class GenerateMetadataJob extends TimedJob { - // Default memory limit for metadata generation (256 MBytes). - protected const DEFAULT_MEMORY_LIMIT = 256; + // Default file size limit for metadata generation (MBytes). + protected const DEFAULT_MAX_FILESIZE = 256; public function __construct( ITimeFactory $time, @@ -103,11 +103,12 @@ private function scanFolder(Folder $folder): void { continue; } - // Don't generate metadata for files bigger than metadata_max_memory + // Don't generate metadata for files bigger than configured metadata_max_filesize + // Files are loaded in memory so very big files can lead to an OOM on the server $nodeSize = $node->getSize(); - $memoryLimit = $this->config->getSystemValueInt('metadata_max_memory', self::DEFAULT_MEMORY_LIMIT); - if ($nodeSize > $memoryLimit * 1000000) { - $this->logger->debug("Skipping generating metadata for fileid " . $node->getId() . " as its size exceeds configured 'metadata_max_memory'."); + $nodeLimit = $this->config->getSystemValueInt('metadata_max_filesize', self::DEFAULT_MAX_FILESIZE); + if ($nodeSize > $nodeLimit * 1000000) { + $this->logger->debug("Skipping generating metadata for fileid " . $node->getId() . " as its size exceeds configured 'metadata_max_filesize'."); continue; }