From 881dd126221abb1ad039913cbc569b16529f99bd Mon Sep 17 00:00:00 2001 From: yemkareems Date: Thu, 16 May 2024 16:48:47 +0530 Subject: [PATCH 1/2] fix: delete user credentials stored in storages_credentials when user gets deleted Signed-off-by: yemkareems [skip ci] --- lib/private/User/Listeners/BeforeUserDeletedListener.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/private/User/Listeners/BeforeUserDeletedListener.php b/lib/private/User/Listeners/BeforeUserDeletedListener.php index ec1f80c5413a8..42d07a51682ac 100644 --- a/lib/private/User/Listeners/BeforeUserDeletedListener.php +++ b/lib/private/User/Listeners/BeforeUserDeletedListener.php @@ -35,10 +35,12 @@ */ class BeforeUserDeletedListener implements IEventListener { private IAvatarManager $avatarManager; + private ICredentialsManager $credentialsManager; private LoggerInterface $logger; - public function __construct(LoggerInterface $logger, IAvatarManager $avatarManager) { + public function __construct(LoggerInterface $logger, IAvatarManager $avatarManager, ICredentialsManager $credentialsManager) { $this->avatarManager = $avatarManager; + $this->credentialsManager = $credentialsManager; $this->logger = $logger; } @@ -61,5 +63,7 @@ public function handle(Event $event): void { 'exception' => $e, ]); } + // Delete storages credentials on user deletion + $this->credentialsManager->erase($user->getUID()); } } From daca6f8acda9136c4e14c4325e2790376ab61967 Mon Sep 17 00:00:00 2001 From: yemkareems Date: Tue, 11 Jun 2024 10:31:13 +0530 Subject: [PATCH 2/2] fix: added missing ICredentialsManager fix: added missing ICredentialsManager Signed-off-by: yemkareems --- lib/private/User/Listeners/BeforeUserDeletedListener.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/private/User/Listeners/BeforeUserDeletedListener.php b/lib/private/User/Listeners/BeforeUserDeletedListener.php index 42d07a51682ac..a19f1dda791a1 100644 --- a/lib/private/User/Listeners/BeforeUserDeletedListener.php +++ b/lib/private/User/Listeners/BeforeUserDeletedListener.php @@ -25,9 +25,10 @@ use OCP\EventDispatcher\Event; use OCP\EventDispatcher\IEventListener; -use OCP\User\Events\BeforeUserDeletedEvent; use OCP\Files\NotFoundException; use OCP\IAvatarManager; +use OCP\Security\ICredentialsManager; +use OCP\User\Events\BeforeUserDeletedEvent; use Psr\Log\LoggerInterface; /**