Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Foregin_check=0 changes the sql result. #35

Open
hrach opened this issue Dec 2, 2015 · 1 comment
Open

Foregin_check=0 changes the sql result. #35

hrach opened this issue Dec 2, 2015 · 1 comment
Labels
bug
Milestone
v4

Comments

@hrach
Copy link
Member

hrach commented Dec 2, 2015

We set foreign_key_checks = 0 and that's have some consequences.

Running migrations with ON DELETE RESTRICT produces table with ON DELETE NO ACTION. In MySQL they are identical, still, I see this as a bug.

Also, disabled foreign_key_check may lead to hard-to-catch errors and we should not enable it by default. A migration can enable it by itself. So, I suggest removing it.
@hrach hrach added the bug label Dec 2, 2015
@JanTvrdik
Copy link
Member

unfortunately removing it would be a BC break, maybe wait for 4.0?

@JanTvrdik JanTvrdik added this to the v4 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v4
Development

No branches or pull requests
2 participants
@JanTvrdik @hrach