Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of cpu is not adapted for fastp tool #270

Closed
mAGLAVE opened this issue Aug 25, 2023 · 2 comments
Closed

Number of cpu is not adapted for fastp tool #270

mAGLAVE opened this issue Aug 25, 2023 · 2 comments
Labels
bug Something isn't working upstream

Comments

@mAGLAVE
Copy link

mAGLAVE commented Aug 25, 2023

Description of the bug

Hello,
The number of cpu for fastp is not adapted. The --thread option is for worker threads only. Not for all threads used by the tool.

OpenGene/fastp#169:

--thread 2 means use 2 processing worker threads.
Besides the worker threads, fastp uses one master thread, one loader thread, and one or two writer thread (depends on SE or PE).

So it should be --thread (( $task.cpus - 3 )) in nf-core-smrnaseq/2.2.1/modules/nf-core/fastp/main.nf, line 42.

Command used and terminal output

No response

Relevant files

No response

System information

No response

@mAGLAVE mAGLAVE added the bug Something isn't working label Aug 25, 2023
@apeltzer
Copy link
Member

This is actually something we should address upstream in https://github.com/nf-core/modules

@mAGLAVE
Copy link
Author

mAGLAVE commented Aug 30, 2023

ok, I'm going to do that. Thank you!

@mAGLAVE mAGLAVE closed this as completed Aug 30, 2023
nschcolnicov pushed a commit that referenced this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

2 participants